Update Phoenix project detection#351
Closed
J3RN wants to merge 2 commits intotonini:masterfrom
J3RN:update_alchemist-phoenix-project-p
Closed
Update Phoenix project detection#351J3RN wants to merge 2 commits intotonini:masterfrom J3RN:update_alchemist-phoenix-project-p
J3RN wants to merge 2 commits intotonini:masterfrom
J3RN:update_alchemist-phoenix-project-p
Conversation
Unfortunately, modern phoenix projects no longer have a "web" directory, opting instead for a "lib/<project_name>_web" directory. This is mentioned in passing on the "Up and Running" page for Phoenix: https://hexdocs.pm/phoenix/up_and_running.html#content. Since it would be difficult to ascertain the name of the project in order to check this directory explicitly, I opted instead to check whether the string ":phoenix" occurs in the "mix.exs" file of the project. This would be expected in the dependencies section of that file. We could, alternately, check for the existence of a "lib/*_web" directory.
Author
Author
|
Closing in favor of #352 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello! 👋
I noticed that modern phoenix projects no longer have a
webdirectory, opting instead for alib/<project_name>_webdirectory. This is mentioned in passing on the "Up and Running" page for Phoenix. Sincealchemist-phoenix-project-plooks for a project-root "web" directory, it was failing to detect my phoenix projects.I figured it would be difficult to ascertain the name of the project in order to check for a
lib/<project_name>_webdirectory explicitly, I opted instead to check whether the string ":phoenix" occurs in themix.exsfile of the project. This would be expected in the dependencies section of that file.We could, alternately, check for the existence of a
lib/*_webdirectory. I'm totally open to feedback on this! 😄