Run tests with Emacs' compile function#329
Open
bschmeck wants to merge 7 commits intotonini:masterfrom
Open
Conversation
added 7 commits
October 26, 2017 18:00
Provide default keybindings for compilation mode.
Contributor
Author
|
I'll also work on cleaning up those test failures if there's interest in this PR. |
Owner
|
@bschmeck I really like your idea. 👍 Could you try to fix the tests and I'll try to have a look at it by myself a soon as possible. |
|
Does it color the stack traces as well? I see |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By using Emacs' native
compilefunction, we can take advantage of the built-in features of compilation mode for free. That lets us do things like move between failures, open the relevant file and line from the stacktrace automatically and re-run the tests with a single keystroke. I was surprised at how little was required to get it all hooked up, honestly.There's a little more work to be done: I haven't tried to integrate the "test after save" hook, and the face used by the stacktrace right now is ugly. But, this change does what I need it to and I wanted to see if there was any interest in merging something like this before I devoted time to features I don't personally use. I'm happy to keep running a forked version if you want to keep the current implementation of test reports.
This change was inspired by rspec-mode