feature/goto-definition-prompts-for-empty-scope#289
Open
kisp wants to merge 1 commit intotonini:masterfrom
kisp:feature/goto-definition-prompts-for-empty-scope
Open
feature/goto-definition-prompts-for-empty-scope#289kisp wants to merge 1 commit intotonini:masterfrom kisp:feature/goto-definition-prompts-for-empty-scope
kisp wants to merge 1 commit intotonini:masterfrom
kisp:feature/goto-definition-prompts-for-empty-scope
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I have a small change here for
alchemist-goto-definition-at-point. If no scope can be found, i.e. if(alchemist-scope-expression)returns"", the user is prompted in the minibuffer.The rationale for this is that sometimes I would like to jump to a definition that is not written somewhere in the current buffer. So instead of writing this into the buffer in order to be able to jump there, I would prefer to write it into the minibuffer.
Could you help to make this pull request even nicer?
alchemist-goto--open-definition. Should I do something differently?