Fix: Improve X media extraction and manual cookie fallback#76
Open
SiIverAsh wants to merge 1 commit intotonhowtf:mainfrom
Open
Fix: Improve X media extraction and manual cookie fallback#76SiIverAsh wants to merge 1 commit intotonhowtf:mainfrom
SiIverAsh wants to merge 1 commit intotonhowtf:mainfrom
Conversation
Owner
|
哥们儿,你根本不知道 omniget 项目能多一个贡献者我有多开心!你那个 PR 我今天肯定会抽时间看的!进我们 Discord 吧,可以看到最新动态,有啥事也能快速找到我,我基本上是秒回的,很少会拖着不回。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves X media extraction and fallback behavior.
Changes
cookies-from-browserwhen an explicitCookie:header is already providedWhy
Some X posts could fail with
No media found in tweeteven when media existed.There were several failure modes behind that:
This PR makes the extraction path more robust and adds a manual cookie fallback when automatic cookie handling is not enough.
Validation
Tested locally with:
No media found in tweet