Open
Conversation
This fix enables other terminals to be used through the TERM variable.
Macro concatenation only worked on gcc, glang tool got pretty confused and changed the comments inside the macro to a single space, witch after some research I discovered it was the documented behaviour for a comment inside a macro and that gcc was doing the resolution wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr is solving two issues for me.
First 758deba is solving a wrong behavior with the macro comment turning in to nothing instead of a space. This is a wrong behavior that conflicts with macro ISO and makes clang tools go crazy.
Second, in order to enable cpp17 I had to get rid of the
registerkeyword. This keyword is deprecated since cpp11 and cpp17 hard deprecated it.source: https://en.cppreference.com/w/cpp/language/storage_duration