-
Notifications
You must be signed in to change notification settings - Fork 209
Add CLI option for a custom host suffix #373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
strohel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Štěpán, thanks for your contribution and sorry for the delay reviewing.
This makes sense as a feature and looks good! I only have some nits. I assume you're using (therefore testing) this branch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution to innernet @HaroldVemeno! Sorry for getting so late to this. @strohel has been on a leave lately.
This looks good. I've also tested locally this works. I think we can merge this. Maybe a final check from @mbernat or @bschwind would be nice. .)
PS: Hi from Prague!
mbernat
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Post-merge LGTM, neat!
Adds a
--host-suffixoption to the client and server, that overrides the default<interface>.wg. This required some refactoring ofHostOptand its use, as the way it was used was a little short-sighted.