Canceling trades if the minimum value isn't reached

[Nakroma]

So I noticed sometimes the bots want to send ~20 cards for 400 points (for example, when my min_val is 300) and a lot of trades would fail due to faster speed of other people or I don't know why. (Reason: Trade Impossible). The few cards that made it trough often don't reach my minimum value.
So far I was lucky enough to get them all in the half hour period where you can cancel them, but this isn't always the case.

I updated it so it checks after all the cards where sent if the minimum value was reached, and if not cancels all the outgoing trades made from that.
I hope I hit your function naming / commenting style right, also I accidently made a merge commit message, sorry about that.

[tomreece]

Nice implementation! A few questions:

1. Do you think there is any risk of drawing attention to your account by cancelling many trades like this? For example: I've never known what the PucaTrade setting that says "Prevent interaction with difficult traders" (https://pucatrade.com/account/settings) actually does. I guess they do offer the 30 minute window for a reason, hopefully they wouldn't punish us for using it.
2. If you commit to send a card and then cancel it, I believe it's removed from your Haves list. This is why I've always been too lazy to implement this feature. I thought that would annoy users and didn't want to deal with it. Do you think we should solve for this or just let it be. Users can always check their histories every so often and add back cards that were cancelled so not too big of a deal.
3. I think we should make this a toggleable mode, probably off by default, but perhaps on. I can't really guess whether it's worse to sometimes make a lower value trade or potentially have to re-add cards to your Haves list all the time.
4. Do you think this will interfere with add-on finding negatively? For me, there have been multiple occurrences where Pucauto initially created a bundle 50 or so points under my min_value of 150, but then add-ons trades put me back on track.

Thanks for your contribution! I look forward to discussing this a bit.

[Nakroma]

1. I tried googling a bit, either its a placebo or just filters out users with bad sending time, not confirming arrival etc. not cancelling out. And even if it would, I at least would still cancel them manually so it doesnt make a difference.
2. Maybe print some kind of notification that you need to readd a few items? This doesn't happen that often, and when it happens its usually just one or two cards so I don't think its a big deal.
3. Thats a good idea, yeah.
4. I have no idea honestly since this never occured for me.

[tomreece]

@Nakroma Have you been using this code successfully? What have your results been?

[Nakroma]

Yeah, its doing good. Way better having to re-add something to the want list than accidently sending out ~100 points of cards. Its not like its hard to code either, I just dont have time due to my finals at the moment. So far I don't think anything negative actually happens, im cancelling like almost once a day and nothing is different, but maybe I could write the support and ask them.