-
Notifications
You must be signed in to change notification settings - Fork 17
Add Venus E 3.0 device type #182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughAdds support for the Venus E 3.0 device type (VNSE3-x) by extending Venus device type recognition. Updates documentation (CHANGELOG, README, docs) and translations (en, de) to mention VNSE3-0 alongside existing HMG types. No API signatures or control flow beyond device type matching are changed. Changes
Sequence Diagram(s)sequenceDiagram
participant U as User / Add-on Config
participant R as Device Resolver
participant V as Venus Device
Note over U,R: Config includes deviceType (e.g., HMG-x or VNSE3-x) and deviceId
U->>R: Submit deviceType + deviceId
R->>V: Initialize/resolve Venus device with provided deviceType
alt Supported deviceType (HMG or VNSE3)
V-->>R: Recognized
R-->>U: Proceed to connect/subscribe
else Unsupported
V-->>R: Not recognized
R-->>U: Report configuration error
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
CHANGELOG.md (1)
10-10: Replace placeholder with PR number.Use the actual PR reference instead of
#??.-- Venus: Add support for Venus E 3.0 device type (VNSE3-0) (#??) +- Venus: Add support for Venus E 3.0 device type (VNSE3-0) (#182)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (6)
CHANGELOG.md(1 hunks)README.md(1 hunks)docs/venus.md(1 hunks)ha_addon/translations/de.yaml(1 hunks)ha_addon/translations/en.yaml(1 hunks)src/device/venus.ts(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
- GitHub Check: build (linux/arm64)
- GitHub Check: build (linux/amd64)
- GitHub Check: build (linux/arm/v7)
- GitHub Check: build-addon (linux/arm64)
- GitHub Check: build-addon (linux/arm/v7)
🔇 Additional comments (5)
docs/venus.md (1)
81-81: LGTM: VNSE3 type documented alongside HMG.Please confirm that device topics using VNSE3-x (e.g., VNSE3-0) behave identically to HMG-x in your local tests/subscriptions.
README.md (1)
316-316: LGTM: Device type list now includes VNSE3-X.Consider adding a short note that “Venus Device Commands” apply to both HMG and VNSE3 for clarity in docs.
ha_addon/translations/en.yaml (1)
31-31: LGTM: Add-on description updated to include VNSE3-0.ha_addon/translations/de.yaml (1)
31-31: LGTM: German translation includes VNSE3-0 example.src/device/venus.ts (1)
137-137: LGTM — VNSE3 registered as Venus base type. Repo-wide search found no code-level enums/validation/schemas preventing VNSE3; occurrences are limited to docs/translations/README (informational).
Summary
Testing
https://chatgpt.com/codex/tasks/task_e_68d25137c340832eb823b915f611914e
Summary by CodeRabbit