Skip to content

Feature/ref point replacement#1

Open
koraberisha wants to merge 2 commits intomasterfrom
feature/ref-point-replacement
Open

Feature/ref point replacement#1
koraberisha wants to merge 2 commits intomasterfrom
feature/ref-point-replacement

Conversation

@koraberisha
Copy link
Copy Markdown
Collaborator

As it says in the commit messages, not much changes!

@koraberisha koraberisha requested review from secemp9 and tomoqt March 23, 2025 17:53
Copy link
Copy Markdown
Owner

@tomoqt tomoqt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since we also reproject optionally in the MLP, we also recalculate the reference point there.

there's a few ways to probably do this, since we could decide to just stay with the one we compute at the beginning and pass it around, or as currently we recompute it. probably makes more sense to actually pass it around, as in that situation (in lines 145-147) x is actually still not mapped back. in any case, probably it's cleaner to have a function that just does the reference point computation. also note, that in this case it's still leaking!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants