Open
Conversation
tomoqt
requested changes
Mar 23, 2025
Owner
tomoqt
left a comment
There was a problem hiding this comment.
since we also reproject optionally in the MLP, we also recalculate the reference point there.
there's a few ways to probably do this, since we could decide to just stay with the one we compute at the beginning and pass it around, or as currently we recompute it. probably makes more sense to actually pass it around, as in that situation (in lines 145-147) x is actually still not mapped back. in any case, probably it's cleaner to have a function that just does the reference point computation. also note, that in this case it's still leaking!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As it says in the commit messages, not much changes!