Skip to content

Bring backbone-view-model to the future #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
cpubot wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Bring backbone-view-model to the future #7

cpubot wants to merge 3 commits into from

Conversation

@cpubot
Copy link

@cpubot cpubot commented Oct 14, 2014

This pull request includes a few of enhancements.

  • Use bower to manage dependencies
  • Fix a bug which breaks the binding of ViewModels to their source_models in Underscore >= 1.7.0
  • Use memory safe listenTo to listen to source_model change events

Thanks for the plugin!

cpubot added 3 commits October 13, 2014 17:31
@cpubot
Use bower to manage dependencies
0ff7693
@cpubot
Fix bindToChangesInSourceModel when source_model is not an array
c6e0442 
_.union in underscore < 1.7.0 wrapped non-array values into an array.
1.7.0 does not allow this, which breaks the binding of ViewModels to
their source models. Update the initialization of the
sourceModel variable to wrap an array around source_model so that we
enter the _.each loop properly.
@cpubot
Use memory safe listenTo to listen to source_model change events
e7472fe
@bretmorris
Copy link

bretmorris commented Oct 14, 2014

LOVE THIS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cpubot @bretmorris