Skip to content

Add test for packets over 1514 bytes #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
danielg55 wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Add test for packets over 1514 bytes #58

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
432bba5
Add test for packets over 1514 bytes
danielg55 Apr 6, 2021
e265bf3
Fix test
danielg55 Apr 6, 2021
fc8d4e8
Black fix
danielg55 Apr 6, 2021
0ffd513
Fix set env
danielg55 Apr 6, 2021
588dfb8
Fix black
danielg55 Apr 6, 2021
c621ce1
Fix
danielg55 Apr 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion marine/marine.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ class Marine:

def __init__(self, epan_auto_reset_count: Optional[int] = None):
if not os.getenv("WIRESHARK_DATA_DIR"):
os.putenv("WIRESHARK_DATA_DIR", str(MARINE_DATA_DIR))
os.environ["WIRESHARK_DATA_DIR"] = str(MARINE_DATA_DIR)
try:
cdll.LoadLibrary(MARINE_NAME)
except Exception:
Expand Down
4 changes: 4 additions & 0 deletions tests/marine/test_marine.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1025,3 +1025,7 @@ def test_parse_fields_preserves_order(marine_instance: Marine, tcp_packet: bytes
"udp.srcport": None,
"tcp.srcport": "16424",
}


def test_filter_packet_larger_than_1514(marine_instance: Marine):
assert not marine_instance.filter(b"a" * 2500, display_filter="frame contains test")
Copy link
Owner

@tomlegkov tomlegkov Apr 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should use a valid packet here to make sure dissection works properly for big packets