Allow supporting other preferred languages#28
Open
paulrolfe wants to merge 10 commits intotomkowz:swift3from
Open
Allow supporting other preferred languages#28paulrolfe wants to merge 10 commits intotomkowz:swift3from
paulrolfe wants to merge 10 commits intotomkowz:swift3from
Conversation
paulrolfe
changed the title
…into Snupps-swift4
paulrolfe
force-pushed
the
pr/preferred-ordering
branch
from
5252b59 to
4a08d3d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of just using the first supported language, look at all the preferred ones, trying to return one for which the language file exists. And if we have none, just return the first one.
This solves the problem where your project has localized something else in a region specific language, but still want to use the a general language (without region) for the base translations.
For Example:
fr-FRon one file that should be specific to France.fr.jsonfor the base translations.fr-FR.json, but if it doesn't exist will usefr.json, assuming that is another supported language in your project.