feat: custom mode user-controlled weight/reps (PRD #51 US2)#53
Open
feat: custom mode user-controlled weight/reps (PRD #51 US2)#53
Conversation
…back, blank replacement Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…nputs Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
changeRepsdomain method + event + API mutation for custom mode reps inputNumericalInputfields (weight + reps) instead of sliderprogressionModefrom mesocycle to workout UI via enrichedgetWorkoutreturn typeCloses PRD #51 User Story 2: "As a user who prefers manual control, I want to enter my own weight/reps each workout so that the app doesn't override my programming decisions."
Test plan
pnpm typecheck— 0 errorspnpm lint— 0 errors (6 pre-existing warnings)pnpm knip— cleanpnpm test— 332/332 passingFindings
exerciseAssesmentonFinishedWorkingExerciseis now nullable — downstreamgetProgressionTypeguards for null but custom mode never reachesextendMicrocycle(throws)progressionModeis NOT onworkoutSchema(causes issues in internal workout construction); instead enriched at thegetWorkoutAPI boundaryExerciseRepsChangedevent only updates pending sets (done/failed sets keep their reps)🤖 Generated with Claude Code