Conversation
![bridgecrew-dev[bot]](https://avatars.githubusercontent.com/in/114125?s=60&v=4){kind=small}
| # bucket does not have versioning | ||
| bucket = "${local.resource_prefix.value}-financials" | ||
| acl = "private" | ||
| acl = "public" |
There was a problem hiding this comment.
Ensure S3 buckets should have event notifications enabled
Resource: aws_s3_bucket.financials | Bridgecrew ID: BC_AWS_LOGGING_36 | Checkov ID: CKV2_AWS_62
| # bucket does not have versioning | ||
| bucket = "${local.resource_prefix.value}-financials" | ||
| acl = "private" | ||
| acl = "public" |
There was a problem hiding this comment.
Ensure S3 Bucket has public access blocks
Resource: aws_s3_bucket.financials | Bridgecrew ID: BC_AWS_NETWORKING_52 | Checkov ID: CKV2_AWS_6
| # bucket does not have versioning | ||
| bucket = "${local.resource_prefix.value}-financials" | ||
| acl = "private" | ||
| acl = "public" |
There was a problem hiding this comment.
Ensure that an S3 bucket has a lifecycle configuration
Resource: aws_s3_bucket.financials | Bridgecrew ID: BC_AWS_LOGGING_35 | Checkov ID: CKV2_AWS_61
| # bucket does not have versioning | ||
| bucket = "${local.resource_prefix.value}-financials" | ||
| acl = "private" | ||
| acl = "public" |
There was a problem hiding this comment.
Ensure S3 buckets are encrypted with KMS by default
Resource: aws_s3_bucket.financials | Bridgecrew ID: BC_AWS_GENERAL_56 | Checkov ID: CKV_AWS_145
How to Fix
resource "aws_s3_bucket" "bucket_name" {
bucket = "bucket_good"
}
+ resource "aws_s3_bucket_server_side_encryption_configuration" "good_sse_1" {
+ bucket = aws_s3_bucket.bucket_name.bucket
+
+ rule {
+ apply_server_side_encryption_by_default {
+ kms_master_key_id = aws_kms_key.mykey.arn
+ sse_algorithm = "aws:kms"
+ }
+ }
+ }Description
Encrypting your data and resources with KMS helps protect your data from unauthorized access or tampering. By encrypting your data, you can ensure that only authorized users can access and decrypt the data, and that the data is protected while in storage or in transit. Such action can help protect against external threats such as hackers or malware, as well as internal threats such as accidental or unauthorized access.| # bucket does not have versioning | ||
| bucket = "${local.resource_prefix.value}-financials" | ||
| acl = "private" | ||
| acl = "public" |
There was a problem hiding this comment.
Ensure S3 bucket has cross-region replication enabled
Resource: aws_s3_bucket.financials | Bridgecrew ID: BC_AWS_GENERAL_72 | Checkov ID: CKV_AWS_144
| # bucket does not have versioning | ||
| bucket = "${local.resource_prefix.value}-financials" | ||
| acl = "private" | ||
| acl = "public" |
There was a problem hiding this comment.
Ensure AWS S3 object versioning is enabled
Resource: aws_s3_bucket.financials | Bridgecrew ID: BC_AWS_S3_16 | Checkov ID: CKV_AWS_21
Benchmarks
- PCI-DSS V3.2.1 10.5.3
- FEDRAMP (MODERATE) CP-10, SI-12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.