Allow to override handleOnClick at the toast message level#18
Open
antoineverger wants to merge 3 commits intotomchentw:masterfrom
collectai:allow-handleonclick-override-at-the-message-level
Open
Allow to override handleOnClick at the toast message level#18antoineverger wants to merge 3 commits intotomchentw:masterfrom collectai:allow-handleonclick-override-at-the-message-level
antoineverger wants to merge 3 commits intotomchentw:masterfrom
collectai:allow-handleonclick-override-at-the-message-level
Conversation
Author
|
Any news on merging the PR ? |
# Conflicts: # lib/ToastContainer.js # src/ToastContainer.js
# Conflicts: # lib/ToastContainer.js # src/ToastContainer.js
Author
|
I merged my change with the latest changes on master, @tomchentw do you think you could merge it ? Do you want me to do some changes/adjustments ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.