Fixed zoom detection for webkit(desktop) and Issue #41#46
Fixed zoom detection for webkit(desktop) and Issue #41#46bitjoo wants to merge 4 commits intotombigel:masterfrom bitjoo:master
Conversation
|
@BitWire cool, thanks! |
|
Manually applied the patch and ran some basic tests (chrome 30 on mac) and seems to work great. Did you find issues or any thoughts on officially merging? |
|
Because document.width was deprecated and is now undefined in Chrome 30, I made some changes to my code and using the opera detection for webkit now. Please have a look. |
|
@BitWire Doesn't look like your latest pull request is working anymore. Might it be possible to use window.devicePixelRatio now, which has been implemented in Chrome since v31? Cheers! |
|
@nhodges Thank you for your hint. Yes, you can use window.devicePixelRatio. Since Chrome 31 it takes full-page zoom, but not pinch zoom, into account. To get sure, I added a solution with a SVG (iframes not supported). I had to change the browser detection as well, because in Chrome 31 they removed support for the prefixed -webkit-marquee. If you want to support only the latest browsers for full-page zoom, you can get rid of this plugin and just use window.devicePixelRatio (since Firefox 18, Chrome 31 and IE11, it has the same behaviour). |
I have tested my webkit patch in the latest chromium 28. And on Windows Chrome 27.
Worked with devtools on the right side, activated sidbar and in iframes as well.
I have also fixed the uncaught type exception bug (#41).