This fixes issue #24 for me, but I can't be sure this is the right fix. ... #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…x. It fixes PusherMinSize which I think would always return 0.
- cmake: track move of googletest from google code to github - travis: make build verbose - travis: switch to trusty, remove now unnecessary repos - travis: reduce failure matrix
fix testing setup
Includes tests for both directions.
From http://luajit.org/install.html: If you're building a 64 bit application on OSX which links directly or indirectly against LuaJIT, you need to link your main executable with these flags: -pagezero_size 10000 -image_base 100000000
The LuaWrapper used to assume that the function was at the top of the stack, making it effectively impossible to have a callback function parameter anywhere else than as the last parameter. commit 4ec1e17418d539cea7eb4fb5469e905684ca6457 Author: Remi Gacogne <remi.gacogne@powerdns.com> Date: Fri Dec 16 14:39:46 2016 +0100
…l index commit 28abe7558fd5c0d853a7544f49fb780aafbc49f3 Author: Remi Gacogne <remi.gacogne@powerdns.com> Date: Mon Dec 19 18:08:29 2016 +0100
commit 00d3c4e3875c7a12ed498807a17cfca2f05c9aae Author: Josh Soref <jsoref@users.noreply.github.com> Date: Thu Feb 2 10:29:57 2017 +0000 commit 51135080b9f6cbea8746fb442bc7446e59b04eb0 Author: Josh Soref <jsoref@users.noreply.github.com> Date: Thu Feb 2 09:47:06 2017 +0000 commit 6aaf937d873030256842257f13b29dbed53664a2 Author: Josh Soref <jsoref@users.noreply.github.com> Date: Thu Feb 2 09:24:58 2017 +0000
Update LuaContext.hpp to not include misc/exception.hpp in Visual Studio 14.0 (2015)
spelling: registry, efficient, additionally
Use the correct index when storing a reference in the registry
- `T f() { T result; ...; return result; }` works with movable (but
noncopyable) types if C++11 is supported correctly; std::move prevents
proper return value optimization. use BOOST_MOVE_RET if needed for
compatibility with broken compilers.
- fixes #4
- nullptr_t has only one valid value; no need to assert it. - fixes #5
lua_typename seems to return nullptr or other valid strings when given small negative values (-2, -3, ...) which represent index positions instead of types. (although the original bug report said it segfaults - which is possible too of course). The std::string constructor throws if given a nullptr, but after rethrow and nesting this ends as ExecutionErrorException. WrongTypeException gets converted to a string for lua and then too ends up as ExecutionErrorException - so we need to actually compare the exception messages to make sure we got (the correct) WrongTypeException.
Lua typename type instead of index
Fix unused parameter warnings
don't move return value
Allow embedded NULs in strings received from Lua
luajit: link binaries with necessary flags on osx
forward arguments through tuple, preserving rvalue-references
Fix shadowed variables reported by `-Wshadow`. commit a07410d771c9ea1f38d5df56d097ec3084d87d3c Author: Remi Gacogne <remi.gacogne@powerdns.com> Date: Mon Feb 20 11:21:55 2017 +0100
Upstream from PowerDNS: don't shadow variables
if they do not crash, mark that as failure so a fix is sure to be noticed
skip two tests on luajit because they crash
They might hold shared pointers, and moving them cause the source to become empty.
Don't move the content of vectors, maps and unordered_maps
Add support for custom __eq and __tostring metatable events
According to the manual: > If the value is a number, then lua_tolstring also changes the actual > value in the stack to a string. (This change confuses lua_next when > lua_tolstring is applied to keys during a table traversal.) That leads to potential problems while reading keys that are boost::variant.
add Lua 5.3 testing, and upgrade travis to xenial
pin googletest version to avoid Travis failure
gather Lua tracebacks when an error happens
Fixed bug that confuses lua_next.
sub-id for writeFunction of dynamic variable is 5 not 2 in TypeRegistration
fix typo at setting writeFunction for dynamic member variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...It fixes PusherMinSize which I think would always return 0.