Improve PHP 8+ compatibility and code quality by upgrading PHPStan and refactoring core classes. #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: tomasmajer <tomasmajer@gmail.com>
…n strict rules Co-authored-by: tomasmajer <tomasmajer@gmail.com>
cursor
bot
force-pushed
the
cursor/skontroluj-spustenie-projektu-na-php-8-adcd
branch
from
d98368f to
b327650
Compare
Co-authored-by: tomasmajer <tomasmajer@gmail.com>
- Added information about enhanced PHPStan configuration - Documented PHP 7.4+ minimum requirement and PHP 8.0+ support - Listed core class improvements with typed properties - Documented bug fixes and compatibility improvements
- Convert all properties to typed properties across all classes and traits - Replace anonymous functions with arrow functions where applicable - Use null coalescing operator (??) for cleaner null handling - Fix strict comparisons for better type safety - Improve error handling in SharedFileShutdown::shouldShutdown() - Modernize all core classes: Emitter, Shutdown implementations, Traits - Maintain backward compatibility while leveraging modern PHP features
- Remove PHP 7.2 and 7.3 from test matrix - Add PHP 8.1, 8.2, and 8.3 to test matrix - Update all GitHub Actions to latest versions (checkout@v4, cache@v3) - Add proper PHP extensions setup (json, redis) - Add composer validation and caching for faster builds - Use PHP 8.1 as standard for static analysis tools - Improve workflow names and job descriptions - Add new security audit workflow with weekly schedule - Enable workflows on pull requests for better CI coverage
- Document removal of PHP 7.2/7.3 support - Add information about modern GitHub Actions setup - Document new security audit workflow - Include CI/CD improvements in changelog
- Delete tests/Handler/exception.log file - File is already properly ignored in .gitignore
- Delete tests/Handler/exception--2025-07-23--17-29--29d60145dd.html - File pattern is already ignored by .gitignore (exception--*)
- Delete tests/Handler/exception--2025-07-23--17-37--c884f00971.html - Clean up test artifacts from repository
- Remove trailing whitespace from Message.php (lines 37-38) - Add build directory creation in GitHub workflow - Improve CodeClimate coverage upload with debug mode - Add continue-on-error for coverage upload resilience - Clean up .gitignore (remove duplicates, add trailing slashes) - Add debug step to troubleshoot coverage file issues
tomaj
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve PHP 8+ compatibility and code quality by upgrading PHPStan and refactoring core classes.
This PR updates the
composer.jsonto reflect PHP 7.4+/8.0+ compatibility and integratesphpstan/phpstan-strict-rules. Core classes (Message,Dispatcher,MessageSerializer) have been refactored to introduce typed properties, strict comparisons, and improved type handling, addressing issues identified by the stricter PHPStan analysis.Open in Web • Open in Cursor