Skip to content

Conversation

@nbfalcon
Copy link

esh-help-eldoc-man-minibuffer-string searches for a "SYNOPSIS" line and then
transforms the string following it. This causes an error if the command has no
synopsis (e.g. ninja). Use -some->> instead of ->>, fixing the error.

`esh-help-eldoc-man-minibuffer-string' searches for a "SYNOPSIS" line and then
transforms the string following it. This causes an `error' if the command has no
synopsis (e.g. `ninja'). Use `-some->>' instead of `->>', fixing the error.
@nbfalcon
Copy link
Author

nbfalcon commented Nov 30, 2020

@hlissner you should bump esh-help if/when this gets merged.

@nbfalcon
Copy link
Author

To reproduce:
0. M-x toggle-debug-on-error

  1. apt-install ninja-build (needed for the man pages to be available)
  2. Open an eshell
  3. Type ninja and start typing arguments (e.g. -C)
  4. Observe that an error is thrown, because ninja's man page has no synopsis

Everything still works with other commands (e.g. gcc).

@ethan-leba
Copy link

@tom-tan anything blocking a merge of this PR? Hitting a similar issue as the PR author

hlissner added a commit to doomemacs/doomemacs that referenced this pull request Apr 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants