Tiny fix of regexp for completions' comments#136
Open
krautcat wants to merge 4 commits intotokuhirom:masterfrom
krautcat:fix-regexp-in-plenv-completions
Open
Tiny fix of regexp for completions' comments#136krautcat wants to merge 4 commits intotokuhirom:masterfrom krautcat:fix-regexp-in-plenv-completions
krautcat wants to merge 4 commits intotokuhirom:masterfrom
krautcat:fix-regexp-in-plenv-completions
Conversation
This fix allows to have comments with `provide plenv completions` not only as standalone strings but also for embedded inline comments. Also, the commit fixes completions for `plenv commands` command and other possibly broken before commands. Signed-off-by: Georgiy Odisharia <math.kraut.cat@gmail.com>
Contributor
Author
|
@tokuhirom, any updates here? |
This fix allows to have comments with `provide plenv completions` not only as standalone strings but also for embedded inline comments. Also, the commit fixes completions for `plenv commands` command and other possibly broken before commands. Signed-off-by: Georgiy Odisharia <math.kraut.cat@gmail.com>
…/plenv into fix-regexp-in-plenv-completions
Collaborator
|
I don't understand why this change is necessary ? (Note: rbenv does not accept this syntax). Could you show us any use-case ? I suppose it is enough to add standalone comment like |
Contributor
Author
|
Basically it's just comment and it could be anywhere in the string. For example, libexec/plenv-commands has following strings: case "$1" in
--complete ) # Provide plenv completions
echo --sh |
Collaborator
|
I suppose we should fix that file and should not fix magic comment rule regexp |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix allows to have comments with
provide plenv completionsnotonly as standalone strings but also for embedded inline comments. Also,
the commit fixes completions for
plenv commandscommand and otherpossibly broken before commands.