feat(l2): zk-dex e2e pipeline by Zena-park · Pull Request #8 · tokamak-network/ethrex

Zena-park · 2026-03-01T11:40:37Z

Summary

End-to-end ZK-DEX pipeline from L1 deployment to Docker-based proving:

L1 deployer pipeline: Automated guest program registration for ZK-DEX on L1
One-command localnet: Setup script for quick local development and testing
Docker-based E2E: Full localnet with real SP1 ZK proofs, including Docker tools for stability
Withdrawal tracker + bridge dashboard: UI for tracking withdrawal status and permissionless batch verification
Full circuit: 7 new operations (settleOrder, deposit, withdrawal, gas fee handling, etc.)
Genesis deployment pipeline: L2 genesis deployment for ZkDex contracts with storage slot fixes
Empty batch auto-verification: Automatic verification of empty batches without requiring ZK proofs
Early batch commit: Trigger early batch commit on pending withdrawals for faster bridge UX
SP1 proof verification fixes: Multiple rounds of debugging and fixing SP1 proof verification (00e errors)

Dependencies

Part 3/4 of stacked PR series. Depends on #7 (Circuit Framework).
Merge order: #6 → #7 → #8 → #9

Test plan

settleOrder lifecycle test and input validation hardening
Byte-level tests for withdrawal, deposit, and gas fee handlers
Genesis state root verification test
Run one-command localnet setup and verify E2E flow
Verify Docker-based E2E produces valid SP1 ZK proofs
Test withdrawal tracker shows correct claim status

github-actions · 2026-03-01T11:40:52Z

🤖 Kimi Code Review

⚠️ Review failed: KIMI_API_KEY secret is not set

Automated review by Kimi (Moonshot AI)

gemini-code-assist · 2026-03-01T11:42:08Z

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request establishes a robust end-to-end infrastructure for the ZK-DEX, enabling its full functionality within the L1/L2 ecosystem. It streamlines deployment, optimizes batch processing by introducing smart contract-level empty batch verification, and enhances user interaction through dedicated UI tools. The changes ensure that the ZK-DEX guest program can operate efficiently with real SP1 proofs, laying the groundwork for advanced decentralized exchange capabilities.

Highlights

ZK-DEX E2E Pipeline: Implemented a comprehensive end-to-end pipeline for ZK-DEX, covering L1 deployment, localnet setup, Docker-based proving with real SP1 ZK proofs, and UI for tracking withdrawals.
Guest Program Registration: Automated the registration of ZK-DEX guest programs and their SP1 verification keys on L1 during deployment, ensuring seamless integration with the on-chain prover.
Empty Batch Auto-Verification: Introduced an optimization to automatically verify empty batches on L1 without requiring ZK proofs, significantly reducing proving time and gas costs for inactive periods.
Early Batch Commit for Withdrawals: Configured the L1 committer to trigger early batch commits when pending withdrawal transactions are detected, improving the user experience for L2-to-L1 bridging.
Expanded ZK-DEX Circuit Operations: The ZK-DEX guest program now supports 7 new operations, including settleOrder, deposit, withdrawal, and gas fee handling, alongside the existing token transfer.
Dockerized Development Environment: Provided one-command localnet setup scripts and Docker Compose configurations for quick local development and testing, including GPU support for SP1 proving.
Withdrawal Tracker and Bridge Dashboard: Added a UI for tracking withdrawal statuses and a bridge dashboard to facilitate permissionless batch verification and user interaction.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

.gitignore
- Added entry for the ZK-DEX localnet runtime directory.
Dockerfile.sp1
- Added a new Dockerfile for building an SP1 ZK-DEX prover image with GPU support, extending the standard ethrex Dockerfile with SP1 toolchain installation and guest program VK copying.
cmd/ethrex/l2/deployer.rs
- Added new CLI options --register-guest-programs and --zk-dex-sp1-vk to the deployer.
- Implemented logic to register guest programs and their SP1 verification keys on L1 during contract deployment.
- Introduced new constants for GuestProgramRegistry and Timelock contract signatures.
crates/common/types/l2/batch.rs
- Added is_empty_batch method to determine if a batch contains no state-changing transactions, along with comprehensive unit tests.
crates/guest-program/bin/sp1-zk-dex/Cargo.toml
- Added substrate-bn and bls12_381 patches for improved cryptographic operations within the ZK-DEX guest program.
crates/guest-program/src/common/app_execution.rs
- Refactored common transaction handling logic into dedicated modules (deposit, eth_transfer, gas_fee, system_call, withdrawal).
- Updated gas calculation to derive per-transaction gas from block headers for accurate fee distribution.
- Modified blob verification to compute the versioned hash directly, skipping expensive KZG proof verification within the zkVM as it's handled on L1.
crates/guest-program/src/common/handlers/constants.rs
- Added a new file centralizing system contract addresses, event topics, and gas cost constants for common transaction handlers.
crates/guest-program/src/common/handlers/deposit.rs
- Added a new file containing the handler for privileged deposit transactions, including calldata parsing to identify the true recipient.
crates/guest-program/src/common/handlers/eth_transfer.rs
- Added a new file containing the handler for simple ETH transfer transactions without calldata.
crates/guest-program/src/common/handlers/gas_fee.rs
- Added a new file implementing detailed gas fee distribution logic, replicating L2 EVM execution for sender debits and credits to coinbase and vaults.
crates/guest-program/src/common/handlers/mod.rs
- Added a new module to organize common transaction handlers.
crates/guest-program/src/common/handlers/system_call.rs
- Added a new file containing the handler for system contract calls and a utility function to check for known system contracts.
crates/guest-program/src/common/handlers/withdrawal.rs
- Added a new file containing the handler for L2-to-L1 withdrawal transactions, including state changes for burning ETH, incrementing message IDs, and generating EVM-matching logs.
crates/guest-program/src/common/incremental_mpt.rs
- Added short-circuit logic to verify_state_proofs and compute_new_state_root for cases with no account proofs or dirty accounts, optimizing empty batch processing.
crates/guest-program/src/common/mod.rs
- Added the handlers module to the common guest program modules.
crates/guest-program/src/programs/zk_dex/DEV.md
- Added a new development document detailing the ZK-DEX full circuit, supported operations, file structure, architecture, storage layout, note/order state machines, events, calldata parsing, and witness analysis.
crates/guest-program/src/programs/zk_dex/circuit.rs
- Expanded DexCircuit to support 8 operation types, including mint, spend, liquidate, convertNote, makeOrder, takeOrder, and settleOrder.
- Implemented calldata parsing and log generation for each new operation type.
- Updated gas cost constants for all supported operations.
crates/guest-program/src/programs/zk_dex/events.rs
- Added a new file for generating EVM-compatible event logs for ZkDex contract operations, including NoteStateChange, OrderTaken, and OrderSettled.
crates/guest-program/src/programs/zk_dex/mod.rs
- Updated the ZkDexGuestProgram description to reflect support for 8 operation types.
- Added new modules (events, notes, orders, storage) to the ZK-DEX program.
- Modified analyze_zk_dex_transactions to extract relevant accounts and storage slots for all new ZK-DEX operations, including handling dynamic array storage and witness trie lookups.
crates/guest-program/src/programs/zk_dex/notes.rs
- Added a new file implementing state transitions for ZkDex note-based operations: mint, spend, liquidate, and convertNote.
crates/guest-program/src/programs/zk_dex/orders.rs
- Added a new file implementing state transitions for ZkDex order book operations: makeOrder, takeOrder, and settleOrder, including RLP decoding for encDatas.
crates/guest-program/src/programs/zk_dex/storage.rs
- Added a new file for computing Solidity-compatible storage slots for ZkDex contracts, including notes, orders, and encrypted notes, and functions for writing Solidity-encoded bytes to storage.
crates/guest-program/src/traits.rs
- Updated the serialize_input test for ZkDexGuestProgram to be conditional on the l2 feature.
crates/l2/Makefile
- Added new Makefile targets for ZK-DEX E2E setup, including localnet and Docker-based commands for starting, stopping, checking status, and cleaning resources.
crates/l2/contracts/src/l1/OnChainProposer.sol
- Modified commitBatch to exempt empty batches from blob requirements in rollup mode.
- Added _isEmptyBatch and _hasNoStateChangingTransactions internal functions to enable proof-free verification for empty batches.
- Removed the onlyOwner modifier from the verifyBatch function to allow permissionless batch verification.
crates/l2/contracts/src/l1/Timelock.sol
- Added a new upgradeVerificationKey function to allow the SECURITY_COUNCIL role to register verification keys for guest programs on the OnChainProposer.
crates/l2/contracts/src/l1/interfaces/ITimelock.sol
- Added the upgradeVerificationKey function signature to the ITimelock interface.
crates/l2/docker-compose-zk-dex-gpu.overrides.yaml
- Added a new Docker Compose override file to enable NVIDIA GPU acceleration for the SP1 prover in the ZK-DEX Docker localnet.
crates/l2/docker-compose-zk-dex-tools.yaml
- Added a new Docker Compose file to set up ZK-DEX development tools, including Blockscout explorers for L1 and L2, a Bridge UI, and a Dashboard, along with a PostgreSQL database and Redis.
crates/l2/docker-compose-zk-dex.overrides.yaml
- Added a new Docker Compose override file for the ZK-DEX E2E pipeline, configuring the contract deployer, L2 node, and SP1 prover to use the ethrex:sp1 image and ZK-DEX guest programs.
crates/l2/programs-zk-dex.toml
- Added a new TOML configuration file for the SP1 prover, specifying 'zk-dex' as the default and enabled guest program for ZK-DEX E2E.
crates/l2/scripts/ZK-DEX-LOCALNET.md
- Added new documentation detailing the ZK-DEX localnet setup, commands, endpoints, verification steps, and file layout.
crates/l2/scripts/zk-dex-docker.sh
- Added a new shell script to manage the Docker-based ZK-DEX localnet, providing commands for starting, stopping, checking status, viewing logs, and cleaning resources, with options for GPU and prover inclusion.
crates/l2/scripts/zk-dex-localnet.sh
- Added a new shell script to manage the native ZK-DEX localnet, automating the setup of L1, contract deployment, L2, and SP1 prover, with commands for start, stop, status, and logs.
crates/l2/sequencer/l1_committer.rs
- Added has_pending_withdrawals function to detect pending L2-to-L1 withdrawal transactions.
- Modified batch assembly to fast-forward empty blocks, skipping heavy processing.
- Updated send_commitment to send EIP-1559 transactions (without blobs) for empty batches in rollup mode.
- Updated resolve_program_type_id to fall back to the ETHREX_GUEST_PROGRAM_ID environment variable if the program ID is not yet stored.
crates/l2/sequencer/l1_proof_sender.rs
- Implemented empty batch auto-verification logic in verify_and_send_proof, allowing proof-free verification for truly empty batches on L1.
crates/l2/sequencer/proof_coordinator.rs
- Added early storage of program_id for a batch to prevent race conditions with the L1 committer.
- Introduced an empty batch response to inform the prover to skip proof generation for auto-verifiable batches.
crates/l2/storage/src/store.rs
- Added get_non_privileged_transactions_by_batch to retrieve the count of non-privileged transactions for a given batch.
crates/l2/tooling/bridge/Dockerfile
- Added a new Dockerfile for the bridge UI, configuring Nginx to serve static HTML files and generate a config.json from environment variables.
crates/l2/tooling/bridge/dashboard.html
- Added a new HTML file for the ZK-DEX localnet dashboard, providing an overview of chain status, services, contract addresses, test accounts, and MetaMask network configurations.
crates/l2/tooling/bridge/entrypoint.sh
- Added a new entrypoint script for the bridge UI Docker container, which dynamically generates a config.json file based on deployed contract addresses from environment variables.
crates/l2/tooling/bridge/index.html
- Added a new HTML file for the ZK-DEX bridge UI, allowing users to connect MetaMask, view L1/L2 balances, and perform ETH deposits and withdrawals.
crates/l2/tooling/bridge/withdraw-status.html
- Added a new HTML file for the ZK-DEX withdrawal tracker, enabling users to view the status of their L2-to-L1 withdrawals through various stages of batch commitment and verification.
docs/design/empty-batch-optimization.md
- Added a new design document detailing the empty batch optimization, including problem analysis, solution architecture, security arguments, and implementation plan for proof-free verification.
scripts/generate-zk-dex-genesis.sh
- Added a new script to generate the L2 genesis JSON with ZkDex contracts pre-deployed, including compilation, bytecode extraction, storage layout verification, and merging into the base genesis file.
tokamak-notes/guest-program-modularization/13-zkdex-genesis-deployment.md
- Added new documentation detailing the ZK-DEX L2 genesis deployment, including contract address assignments, implementation results, execution methods, storage layout, and verification procedures.
tokamak-notes/local-setup-guide.md
- Updated the local setup guide to reflect the new Docker-based ZK-DEX environment, including quick start instructions, proving time benchmarks, Docker Compose configurations, and troubleshooting tips.
tokamak-notes/zk-dex-e2e-design.md
- Added a new design document outlining the ZK-DEX E2E execution, covering goals, core design decisions, current status analysis, architecture, implementation details, and future extensions.
tokamak-notes/zk-dex-progress.md
- Added a new progress document for the ZK-DEX project, detailing the timeline, SP1 ZK-DEX profiling results, E2E localnet benchmarks, Halo2 vs SP1 comparison, L1/L2 infrastructure status, and remaining tasks.

Activity

Initial creation of the pull request as part of a larger series, with a detailed test plan provided by the author.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This is an impressive and comprehensive pull request that delivers a full end-to-end pipeline for the ZK-DEX. The changes are well-structured, introducing a modular framework for app-specific circuits, a complete Docker-based localnet, and significant optimizations like empty batch verification. The code quality is high, with thorough documentation and testing. I have one minor suggestion to improve the readability of a script in the Dockerfile.

Dockerfile.sp1

Migrate the zk-dex guest program from the old keccak-chaining demo (DexProgramInput/execution_program) to the new AppCircuit-based architecture (AppProgramInput/execute_app_circuit with DexCircuit). - Rewrite bin/sp1-zk-dex to use execute_app_circuit(DexCircuit, input) - Add rkyv derives to AppProgramInput, StorageProof, AccountProof - Add ethrex-common dep and secp256k1 SP1 patch to sp1-zk-dex - Delete old execution.rs and types.rs from zk_dex module - Update sp1_benchmark.rs zk-dex input gen to TODO stub (Phase 3) - Replace registry test with DexCircuit-based unit test

Implement prover-side input conversion so the zk-dex guest program receives AppProgramInput (Merkle proofs) from the standard ProgramInput (full ExecutionWitness trie), eliminating the need for coordinator or protocol changes. - Add input_converter module with convert_to_app_input() that rebuilds state/storage tries from ExecutionWitness and extracts Merkle proofs - Replace ZkDexGuestProgram::serialize_input() pass-through with ProgramInput deserialization, transaction analysis, and conversion - Add analyze_zk_dex_transactions() to extract needed accounts and storage slots from batch transactions - Implement generate_zk_dex_input() in sp1_benchmark exercising the full conversion pipeline with mock state tries and transfer txs - Update tests in traits.rs and registry.rs for the new behavior

Timeline, SP1 profiling results (182x cycle reduction), Halo2 vs SP1 decision, L1/L2 infra status, and next steps.

…tration Add deployer support for registering custom guest programs (e.g., zk-dex) on L1 during contract initialization, including GuestProgramRegistry registration and SP1 verification key setup via upgradeVerificationKey(). - Add --register-guest-programs and --zk-dex-sp1-vk CLI options - Add guest program registration loop in initialize_contracts() - Add resolve_deployer_program_type_id() and get_vk_for_program() helpers - Add ZK-DEX E2E Makefile targets (deploy, l2, prover) - Add programs-zk-dex.toml prover config - Add E2E design document

Add mint, spend, liquidate, convertNote, makeOrder, takeOrder, and settleOrder operations to the DexCircuit, matching the ZkDex Solidity contract's state transitions exactly. New files: - storage.rs: slot computation for notes, orders, encryptedNotes - events.rs: NoteStateChange, OrderTaken, OrderSettled log generation - notes.rs: mint/spend/liquidate/convertNote execution - orders.rs: makeOrder/takeOrder/settleOrder execution + RLP decoder Modified: - circuit.rs: ABI selectors, calldata parsing, routing for 8 ops - mod.rs: witness analyzer for all operation storage slots

Extract makerNoteHash (input[1]) and takerStakeNoteHash (input[3]) from settleOrder calldata to include their note_state_slots in the witness. parentNote remains dependent on ExecutionWitness since it's only available in order storage. Also mark storage slot verification as done (slots 3, 4, 14 confirmed via manual inheritance chain trace).

…tness analyzer Read orders.length and parentNote from ExecutionWitness trie to compute exact storage slots for makeOrder (new order fields) and settleOrder (parentNote note state), preventing incremental MPT failures.

- Add full makeOrder→takeOrder→settleOrder lifecycle test (6 note states + order state + result.data) - Add ABI bytes offset/length overflow checks in extract_abi_bytes - Add RLP trailing bytes validation in decode_enc_datas - Add event topic uniqueness and signature verification tests - Add Solidity bytes storage short/long encoding verification tests - Remove DAI TODO (not used), clean up witness analyzer comments

… offsets Build complete pipeline to pre-deploy ZkDex + 6 Groth16 verifiers into L2 genesis block so DEX is available from Block 0. Key changes: - Add generate-zk-dex-genesis.sh: forge build → bytecode extraction → storage layout verification → genesis JSON generation - Generate l2-zk-dex.json with 7 contracts at deterministic addresses - Fix storage slot constants in witness analyzer (no packing gap at slot 2): ENCRYPTED_NOTES_SLOT 3→2, NOTES_SLOT 4→3, ORDERS_SLOT 14→13 - Update localnet script and docker-compose to use l2-zk-dex.json

L2 server mode defaults to TUI monitor which sends all tracing to an in-memory buffer instead of stdout, producing zero log output when redirected to a file. Added --no-monitor flag. Also resolved P2P port 30303 conflict between L1 and L2 by assigning L2 to port 30304. Localnet E2E verified: 7 contracts deployed with correct storage slots.

…ypeId The committer was defaulting to programTypeId=1 (evm-l2) because ETHREX_GUEST_PROGRAM_ID was not set in the localnet script. This caused L1 proof verification to fail (00e) since the VK lookup used the wrong programTypeId. Adding ETHREX_GUEST_PROGRAM_ID=zk-dex ensures batch commits use programTypeId=2, matching the prover's zk-dex guest program. E2E pipeline now fully operational: L1→Deploy→L2→SP1 Prover→L1 Verify.

- Add Section 3: E2E Localnet Benchmark with real measured data - Batch 1: 49 deposits, 5.4M cycles, 3m48s proving - Batch 2: 200 ETH transfers, 15.8M cycles, 6m46s proving - Both verified on L1 successfully - Add resolved issues table (5 major bugs documented) - Update checklist: E2E proof + benchmark complete - Add ZkDex genesis contract addresses to setup guide - Restructure sections for clarity

…ismatch The first batch after genesis may have a different state root than batch 0 when the L2 genesis includes pre-deployed contracts (e.g., ZK-DEX). Since the genesis state root is deterministic and already trusted by the L1 contract, no ZK proof is needed for this transition. - Add genesis transition check in OnChainProposer.verify(): when lastVerifiedBatch == 0 and batch has no state-changing transactions, skip proof verification - Extract _hasNoStateChangingTransactions() helper from _isEmptyBatch() - Fix proof coordinator: when a batch has no prover input but versions match, respond with empty_batch_response instead of version_mismatch

When a user submits a withdrawal on L2, the committer now detects it and triggers an immediate batch commit instead of waiting for the full commit_time_ms interval (e.g. 5 minutes). This significantly reduces withdrawal latency. The existing timer-based commit behavior is preserved for normal (non-withdrawal) traffic.

Consolidate the multi-line if/else/fi block into a compact one-liner for better readability.

…serialize_input Dead code referencing RkyvError and app_input outside the #[cfg(feature = "l2")] block caused 3 compile errors (E0412, E0425, E0308) failing all CI lint jobs.

… pr/zk/03-zk-dex-e2e # Conflicts: # crates/guest-program/src/common/app_execution.rs # crates/guest-program/src/programs/zk_dex/circuit.rs # crates/guest-program/src/programs/zk_dex/mod.rs # crates/l2/contracts/src/l1/OnChainProposer.sol # crates/l2/prover/src/bin/sp1_benchmark.rs

- Remove needless borrows (&data, &slot_word, &preimage, &xxx_sel) - Use .div_ceil(32) instead of manual (x + 31) / 32 - Fix doc list item overindentation in rustdoc comments - Remove unneeded return statement - Allow mixed_case_hex_literals for EIP-55 ETH address constant - Replace map_or(true, ...) with is_none_or(...) in l1_proof_sender

The empty block fast-forward in l1_committer skipped adding empty blocks to current_blocks/current_fee_configs, excluding them from the blob. However, the prover input includes all blocks in the batch range, so verify_blob reconstructed different blob data and KZG verification failed with "Invalid KZG blob proof". Fix: push empty blocks into current_blocks and current_fee_configs before the fast-forward continue, so the blob matches the prover input.

Empty blocks were added to the batch's block list but the blob bundle was not regenerated, causing KZG proof mismatches between the committer and prover. Now generate_blobs_bundle is called in the empty-block path with graceful error handling (pop + break) when blob capacity is exceeded. Also replace undefined Make targets (bridge-address, on-chain-proposer-address) in the integration-test recipe with docker cp from the deployer container.

In based mode, block production is L1-sequenced. The has_pending_withdrawals() scan triggered rapid tiny batch commits, causing the prover to fall behind and stall the pipeline. Skip this optimisation in based mode where it is counterproductive.

Zena-park · 2026-03-03T10:31:58Z

Closing: merging PR #3 and #4 into a combined PR for unified submission.

…to-logout on 401 - Bug #1 (critical): getProgramById → getProgramByProgramId for slug lookup Pass program.id (UUID) to createDeployment and incrementUseCount - Bug #2: incrementUseCount now receives UUID instead of slug - Bug #3: fetch() headers properly merged (options can't overwrite auth) - Bug #8: auto-logout on 401 response (expired token)

…te detection * fix(manager): prompt — download bridge UI source, reorder firewall before tools - Step 6: download bridge UI source files (Dockerfile, HTML, entrypoint.sh) from GitHub before tools compose up (fixes build path not found) - Move firewall (Step 7→6) before tools (Step 6→7) so ports are open for external monitoring before tools deployment - Public URLs already set via VM_IP metadata for dashboard Explorer links * feat(manager): auto-detect deployment success + save & complete button - Monitor: when all services are healthy, show success message with URLs - "배포 완료 — 정보 저장" button saves IP/port to DB, sets phase=running - Navigates to dashboard detail view after save - Guide text: "아래 버튼을 누르면 대시보드 화면으로 이동합니다" * feat(messenger): Open Appchain public interface — API integration, metadata push, publish UX - Replace mock data in OpenL2View with Platform API (getPublicAppchains) - Add registration modal for external appchain publishing (name, RPC, chain ID) - OpenL2DetailView: real screenshots (IPFS), RPC status check, reviews/comments/announcements - L2DetailPublishTab: allow description/screenshots/social links input before publish toggle - Platform server: metadata-push.js — push/delete metadata to GitHub repo via Contents API - New routes: POST /deployments/:id/push-metadata, /delete-metadata - Debounced metadata push (5s) after description/screenshot/social link saves - Security: name length validation, status escalation guard, commit message sanitization, 409 retry - i18n: loading/error/retry/nativeToken/rating/reviews/comments/noScreenshots/announcements - Tests: 24 unit tests (metadata-push), e2e-store.js (11-step lifecycle test) * fix(messenger): add save button for publish tab — persist draft to localStorage before publish * fix(messenger): block publishing with localhost RPC URL — require publicly accessible endpoint * fix(messenger): fix publish toggle disabled for non-local appchains — remove false localhost check * feat(platform): server-side screenshot upload — no Pinata required - POST /api/deployments/:id/screenshots — multer-based image upload (5MB, images only) - platformAPI.uploadScreenshots() — FormData upload to Platform server - L2DetailPublishTab: use server upload when platformId exists, IPFS fallback, data URL fallback - Remove Pinata requirement for screenshot upload button * fix(messenger): detect AWS deployments correctly — show AWS badge, fix L1 chain ID, enable publishing - networkMode detection: config.mode > host_id (AWS) > l1_chain_id > local - L1 chain ID: read from DB l1_chain_id field first, then config fallback - Add AWS (orange), Mainnet (green) badges alongside existing Testnet/Local - Add hostId, publicRpcUrl, deployMethod to L2Config interface * fix(messenger): allow publishing when public URL or remote host exists, not just by networkMode * fix(messenger): add missing DB fields (l1_chain_id, host_id, public_l2_rpc_url) to DeploymentRow - Rust: add l1_chain_id, host_id, platform_deployment_id, public_l2_rpc_url, public_domain to SELECT - TS: add matching fields to DeploymentFromDB interface - Now AWS deployments show correctly (not as Local), L1 Chain ID displays properly * fix(messenger): correct networkMode detection — use l1_port to distinguish local vs testnet - l1_port exists → local (has bundled L1 node in Docker) - host_id exists → AWS (remote deployment) - l1_chain_id exists but no l1_port → testnet (external L1) - Fixes: local Docker showing as Testnet, AWS showing as Local * fix(messenger): detect AWS via config.cloud, read l1ChainId from config fallback * docs: add deployment network mode detection documentation * fix(manager): fix status showing stopped for AI-deploy local Docker — distinguish remote vs local - AI Deploy with ec2IP → SSH remote status check - AI Deploy without ec2IP (local Docker) → local docker compose ps - Remote host deployments → SSH status check - Fixes: local Docker containers showing as stopped, (pending) hostname * fix(messenger): use l2.programSlug for publish instead of non-existent 'ethrex-appchain' - Fixes 'Load failed' error when publishing — Platform has no 'ethrex-appchain' program - L2DetailPublishTab: programId = l2.programSlug || 'evm-l2' - OpenL2View registration modal: programId = 'evm-l2' - Rename labels: '오픈 앱체인 공개' → '앱체인 공개 설정' * fix: critical publish bugs — program lookup by slug, header merge, auto-logout on 401 - Bug #1 (critical): getProgramById → getProgramByProgramId for slug lookup Pass program.id (UUID) to createDeployment and incrementUseCount - Bug #2: incrementUseCount now receives UUID instead of slug - Bug #3: fetch() headers properly merged (options can't overwrite auth) - Bug #8: auto-logout on 401 response (expired token) * feat(messenger): make Platform URL configurable via VITE_PLATFORM_URL env var * feat(messenger): metadata registry submission with auto register/update detection - Add appchain-registry API client with check/submit/status endpoints - Auto-detect register vs update by checking existing file on GitHub main branch - Preserve immutable fields (l2ChainId, nativeToken, createdAt) on updates - Fetch actual chain ID from L2 RPC (eth_chainId) for accuracy - Map social links to correct schema fields (website → top-level, twitter → xUrl, etc.) - Fix bridges.url empty string validation failure (omit if no dashboardUrl) - Add GitHub PR title/body update when resubmitting to existing open PR - Add keychain-based metadata signing (SECURITY_COUNCIL role) - Open PR links in external browser via Tauri shell plugin * fix(messenger): include dashboard URL in metadata — fallback to port 3000 for remote deployments * fix(platform): sync metadata schema fields — resolve URLs from supportResources, explorers, bridges listings.js was reading legacy top-level fields (dashboardUrl, explorerUrl, bridgeUrl) that don't exist in the new appchain metadata schema. Now reads from: - supportResources.dashboardUrl → dashboard_url - explorers[0].url → explorer_url - bridges[0].url → bridge_url - top-level website → operator_website - supportResources xUrl/communityUrl/telegramUrl/documentationUrl → social_links * fix: address PR #66 code review feedback - Add cross-platform keychain support: macOS uses `security` CLI, Windows/Linux uses `keyring` crate via cfg(target_os) (#1) - Restore keychain key validation with allowed prefixes (pinata_, deployer_pk_, ai-) for security boundary (#3) - Add warning log to empty catch block in tools container status (#2) - Extract magic number 9 to LOCAL_L1_CHAIN_ID constant (#4) * fix: address Copilot PR #66 review feedback - Fix signing message indentation bug — spaces before each line caused signature mismatch with server (array.join instead of multiline string) - Fix saveDraft stale state — pass fresh result to avoid missing prNumber - Add NaN timestamp validation in submit endpoint - Add rate limit map cleanup to prevent unbounded memory growth - Strict address validation in getRepoFilePath (0x + 40 hex chars) - findOpenPR verifies actual PR files instead of title-only matching - Remove .deployed-*-tools.env from tracking, add to .gitignore

- Return 503 instead of {exists:false} on check endpoint errors (#1) - Sanitize all error messages — log internally, return generic to client (#2,#3,#4,#5) - Add serverless rate limit limitation comment (#6) - Add console.warn to all empty catch blocks in github-pr.ts (#9,#10,#11) - Note: params as Promise is correct for Next.js 15 (#7,#8)

* feat(platform): add appchain registry API routes to Next.js client Port Express server appchain-registry endpoints to Next.js API routes for Vercel deployment: - GET /api/appchain-registry/check/[l1ChainId]/[stackType]/[identityAddress] - POST /api/appchain-registry/submit - GET /api/appchain-registry/status/[prNumber] Shared logic in lib/appchain-registry.ts and lib/github-pr.ts. * fix: address PR #67 code review feedback - Return 503 instead of {exists:false} on check endpoint errors (#1) - Sanitize all error messages — log internally, return generic to client (#2,#3,#4,#5) - Add serverless rate limit limitation comment (#6) - Add console.warn to all empty catch blocks in github-pr.ts (#9,#10,#11) - Note: params as Promise is correct for Next.js 15 (#7,#8) * fix: address additional Copilot PR #67 review feedback - Add AbortSignal.timeout(15s) to all GitHub API fetch calls - Fix authHeaders error message to list both accepted env vars - Distinguish RPC errors (502) from permission denied (403) in ownership check - Add typeof validation for metadata.signedBy - Add unit test suggestion acknowledged (future work)

Zena-park requested a review from jason-h23 March 1, 2026 11:40

Zena-park mentioned this pull request Mar 1, 2026

chore(l2): docker and production polish #9

Closed

4 tasks

Zena-park changed the title ~~feat(zk-dex): ZK-DEX E2E Pipeline~~ feat(l2): zk-dex e2e pipeline Mar 1, 2026

gemini-code-assist bot reviewed Mar 1, 2026

View reviewed changes

Dockerfile.sp1 Outdated Show resolved Hide resolved

Zena-park force-pushed the pr/zk/02-circuit-framework branch from d8cc431 to 954d730 Compare March 1, 2026 11:46

Zena-park force-pushed the pr/zk/03-zk-dex-e2e branch from 23759c9 to 2d33b67 Compare March 1, 2026 11:46

Zena-park force-pushed the pr/zk/02-circuit-framework branch from 954d730 to 797f1e0 Compare March 1, 2026 12:01

Zena-park force-pushed the pr/zk/03-zk-dex-e2e branch from 2d33b67 to c0623ad Compare March 1, 2026 12:01

Zena-park force-pushed the pr/zk/02-circuit-framework branch from 797f1e0 to eacee43 Compare March 1, 2026 12:04

Zena-park force-pushed the pr/zk/03-zk-dex-e2e branch from c0623ad to 6e74d66 Compare March 1, 2026 12:04

Zena-park force-pushed the pr/zk/02-circuit-framework branch from eacee43 to c863a5c Compare March 1, 2026 12:14

Zena-park force-pushed the pr/zk/03-zk-dex-e2e branch from 6e74d66 to 7ca60e6 Compare March 1, 2026 12:14

This was referenced Mar 1, 2026

feat(l2): guest program modularization core #6

Merged

feat(l2): app-specific circuit framework #7

Merged

Zena-park force-pushed the pr/zk/02-circuit-framework branch from c863a5c to f3296d8 Compare March 1, 2026 12:31

Zena-park force-pushed the pr/zk/03-zk-dex-e2e branch from 7ca60e6 to c777815 Compare March 1, 2026 12:32

Zena-park force-pushed the pr/zk/02-circuit-framework branch from f3296d8 to 872ce31 Compare March 1, 2026 12:46

Zena-park force-pushed the pr/zk/03-zk-dex-e2e branch from c777815 to 56604ad Compare March 1, 2026 12:46

Zena-park force-pushed the pr/zk/02-circuit-framework branch from 872ce31 to 63b8b5e Compare March 1, 2026 13:00

Zena-park force-pushed the pr/zk/03-zk-dex-e2e branch from 56604ad to ccf3106 Compare March 1, 2026 13:05

Zena-park force-pushed the pr/zk/02-circuit-framework branch from 63b8b5e to 57dc13b Compare March 1, 2026 13:19

Zena-park force-pushed the pr/zk/03-zk-dex-e2e branch from ccf3106 to 791d666 Compare March 1, 2026 13:19

Zena-park force-pushed the pr/zk/02-circuit-framework branch from 57dc13b to 059ab6e Compare March 1, 2026 13:57

Zena-park force-pushed the pr/zk/03-zk-dex-e2e branch from 791d666 to 7611496 Compare March 1, 2026 13:57

Zena-park added 4 commits March 1, 2026 23:59

docs(zk): add ZK-DEX project progress summary

e41c3e6

Timeline, SP1 profiling results (182x cycle reduction), Halo2 vs SP1 decision, L1/L2 infra status, and next steps.

Zena-park added 12 commits March 2, 2026 00:00

docs(zk-dex): add L2 genesis deployment plan for ZkDex contracts

3bb463c

style(l2): run cargo fmt on zk-dex e2e code

7f2c47a

Zena-park force-pushed the pr/zk/02-circuit-framework branch from 059ab6e to f04dfd0 Compare March 1, 2026 15:00

Zena-park force-pushed the pr/zk/03-zk-dex-e2e branch from 7611496 to 7f2c47a Compare March 1, 2026 15:00

Zena-park added 2 commits March 2, 2026 08:37

style(docker): simplify solc installation in Dockerfile.sp1

8f47dea

Consolidate the multi-line if/else/fi block into a compact one-liner for better readability.

fix(zk): remove duplicate code outside cfg(feature = "l2") in zk_dex …

e4795d9

…serialize_input Dead code referencing RkyvError and app_input outside the #[cfg(feature = "l2")] block caused 3 compile errors (E0412, E0425, E0308) failing all CI lint jobs.

Zena-park removed the request for review from jason-h23 March 2, 2026 23:32

Zena-park added 3 commits March 3, 2026 09:01

Zena-park force-pushed the pr/zk/03-zk-dex-e2e branch from 0ce6aef to 856de48 Compare March 3, 2026 01:48

Zena-park added 3 commits March 3, 2026 14:03

style: fix rustfmt formatting

a0f3d97

Zena-park closed this Mar 3, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(l2): zk-dex e2e pipeline#8

feat(l2): zk-dex e2e pipeline#8
Zena-park wants to merge 35 commits intopr/zk/02-circuit-frameworkfrom
pr/zk/03-zk-dex-e2e

Zena-park commented Mar 1, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Mar 1, 2026

Uh oh!

gemini-code-assist bot commented Mar 1, 2026

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

Zena-park commented Mar 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

Zena-park commented Mar 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Dependencies

Test plan

Uh oh!

github-actions bot commented Mar 1, 2026

🤖 Kimi Code Review

Uh oh!

gemini-code-assist bot commented Mar 1, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Zena-park commented Mar 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Zena-park commented Mar 1, 2026 •

edited

Loading