Merged
Conversation
Fixes 504 Gateway Timeout in get_devices and get_events. When PostgREST executes RPC functions with array parameters frequently, PostgreSQL switches to a "generic query plan" after 5 executions. For `get_devices` and `get_events` (which run as `SECURITY INVOKER`), the generic plan defaulted to a Sequential Scan over the `devices` and `events` tables, applying the RLS policy `is_auth_in_org_of_alias` to every row and causing massive timeouts (~160s). This commit wraps the queries in Dynamic SQL (`EXECUTE ... USING ...`). This securely preserves the `SECURITY INVOKER` context (ensuring RLS is enforced) while strictly preventing Postgres from caching a generic plan, forcing it to compute an optimal index scan for the provided array on every execution.
…low-query.20.update-squashed
Member
Author
|
TBR. (The migration is already live). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes 504 Gateway Timeout in get_devices and get_events.
When PostgREST executes RPC functions with array parameters frequently,
PostgreSQL switches to a "generic query plan" after 5 executions. For
get_devicesandget_events(which run asSECURITY INVOKER), thegeneric plan defaulted to a Sequential Scan over the
devicesandeventstables, applying the RLS policyis_auth_in_org_of_aliastoevery row and causing massive timeouts (~160s).
This commit wraps the queries in Dynamic SQL (
EXECUTE ... USING ...).This securely preserves the
SECURITY INVOKERcontext (ensuring RLS isenforced) while strictly preventing Postgres from caching a generic plan,
forcing it to compute an optimal index scan for the provided array on
every execution.