Skip to content

fix(core): settings i18n refresh #14760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
darkskygit merged 2 commits into from
Apr 2, 2026
+4 −2
Merged

fix(core): settings i18n refresh #14760

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7cc591b
fix: translation switch
darkskygit Apr 1, 2026
50972b4
fix: lint
darkskygit Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/frontend/core/src/desktop/dialogs/setting/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
import { GlobalContextService } from '@affine/core/modules/global-context';
import { createIsland, type Island } from '@affine/core/utils/island';
import { ServerDeploymentType } from '@affine/graphql';
import { Trans } from '@affine/i18n';
import { Trans, useTranslation } from '@affine/i18n';
import { ContactWithUsIcon } from '@blocksuite/icons/rc';
import { FrameworkScope, useLiveData, useService } from '@toeverything/infra';
import { debounce } from 'lodash-es';
Expand Down Expand Up @@ -72,10 +72,12 @@
scrollAnchor: initialScrollAnchor,
});
const globalContextService = useService(GlobalContextService);
const { i18n } = useTranslation('translation');

const currentServerId = useLiveData(
globalContextService.globalContext.serverId.$
);
const currentLanguageKey = i18n.resolvedLanguage ?? i18n.language;

Check failure on line 80 in packages/frontend/core/src/desktop/dialogs/setting/index.tsx

View workflow job for this annotation

GitHub Actions / Lint

eslint(no-unused-vars) 

Variable 'currentLanguageKey' is declared but never used. Unused variables should start with a '_'.

Check failure on line 80 in packages/frontend/core/src/desktop/dialogs/setting/index.tsx

View workflow job for this annotation

GitHub Actions / Typecheck 

'currentLanguageKey' is declared but its value is never read.
const serversService = useService(ServersService);
const defaultServerService = useService(DefaultServerService);
const currentServer =
Expand Down
2 changes: 1 addition & 1 deletion packages/frontend/i18n/src/react.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,4 @@ export const useI18n = () => {
return useMemo(() => createI18nWrapper(() => i18n), [i18n]);
};

export { I18nextProvider, Trans } from 'react-i18next';
export { I18nextProvider, Trans, useTranslation } from 'react-i18next';
Loading