fix: update guide panel immediately after language switch

[HanaB14]

Summary

Fixes the issue where the left guide panel does not update immediately after switching display language.

Changes

• removed stale memoized options in appearance settings
• updated the guide panel and settings sections to re-render on language switch
• cleaned unused React imports

Testing

• switched between English and Chinese locally
• confirmed the left guide panel updates immediately
• confirmed theme and open-in-app options also update correctly
• verified no page refresh is needed
• tested switching back to English

Demo

Attached a short before/after video showing the fix.

After.mov

Before.mov

Closes #13291

Summary by CodeRabbit

• Refactor
  • Simplified internal code structure in appearance, general, and workspace settings dialogs for improved maintainability.

[coderabbitai]

📝 Walkthrough

Walkthrough

Four settings components have useMemo removed from their computed values, causing these values to recalculate on every render instead of being cached. This ensures they reflect the latest translation function state, addressing language-switch visibility issues in the Settings dialog.

Changes

Cohort / File(s)	Summary
Settings Dialog Memoization Removal packages/frontend/core/src/desktop/dialogs/setting/general-setting/appearance/index.tsx, packages/frontend/core/src/desktop/dialogs/setting/general-setting/appearance/links.tsx, packages/frontend/core/src/desktop/dialogs/setting/general-setting/index.tsx, packages/frontend/core/src/desktop/dialogs/setting/workspace-setting/index.tsx	Removed useMemo wrappers and hooks from computed values (radioItems, options, settings, sidebar items) to ensure recalculation on every render, enabling translation updates to propagate correctly when language changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 Hop, hop, the cache we shed,
Let translations dance instead,
Each render fresh, no memory held,
The words in every language spelled!
Settings bloom in every tongue, 🌍

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main fix: removing stale memoized dependencies to enable immediate guide panel updates after language switching.
Linked Issues check	✅ Passed	All code changes directly address issue #13291 by removing useMemo wrappers from language-dependent UI options, enabling immediate re-renders on language changes.
Out of Scope Changes check	✅ Passed	All changes are directly related to fixing the language switch issue—removing memoization from language-dependent settings to trigger immediate UI updates.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

🧹 Nitpick comments (1)

packages/frontend/core/src/desktop/dialogs/setting/general-setting/index.tsx (1)

65-150: Memoize useGeneralSettingList() and useWorkspaceSettingList() return values to stabilize sidebar memoization.

Both hooks currently return fresh arrays on every render, which invalidates the groups useMemo in setting-sidebar/index.tsx (lines 184–202) despite it depending on these lists. Wrapping each array with useMemo would preserve their identity across renders when dependencies haven't changed, allowing the groups memo to be effective and avoid unnecessary remapping work.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@packages/frontend/core/src/desktop/dialogs/setting/general-setting/index.tsx`
around lines 65 - 150, The hook useGeneralSettingList (and similarly
useWorkspaceSettingList) returns a new array on every render which breaks the
groups memo in setting-sidebar/index.tsx; wrap the returned settings array in
React.useMemo so it only recreates when its real dependencies change (e.g.,
loggedIn, enableEditorSettings, environment, BUILD_CONFIG, hasPaymentFeature,
meetingSettings, t) and return that memoized array from
useGeneralSettingList/useWorkspaceSettingList to stabilize identity and allow
groups useMemo to work properly.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In
`@packages/frontend/core/src/desktop/dialogs/setting/general-setting/index.tsx`:
- Around line 65-150: The hook useGeneralSettingList (and similarly
useWorkspaceSettingList) returns a new array on every render which breaks the
groups memo in setting-sidebar/index.tsx; wrap the returned settings array in
React.useMemo so it only recreates when its real dependencies change (e.g.,
loggedIn, enableEditorSettings, environment, BUILD_CONFIG, hasPaymentFeature,
meetingSettings, t) and return that memoized array from
useGeneralSettingList/useWorkspaceSettingList to stabilize identity and allow
groups useMemo to work properly.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: d0048b65-5014-4344-966f-e479c69998a4

📥 Commits

Reviewing files that changed from the base of the PR and between 91ad783 and ed9747d.

📒 Files selected for processing (4)

• packages/frontend/core/src/desktop/dialogs/setting/general-setting/appearance/index.tsx
• packages/frontend/core/src/desktop/dialogs/setting/general-setting/appearance/links.tsx
• packages/frontend/core/src/desktop/dialogs/setting/general-setting/index.tsx
• packages/frontend/core/src/desktop/dialogs/setting/workspace-setting/index.tsx

[darkskygit]

reolaced by #14760