Fix HTML markup issues and owlCarousel autoplay runtime error#1
Open
tobibako45 wants to merge 2 commits intomasterfrom
Open
Fix HTML markup issues and owlCarousel autoplay runtime error#1tobibako45 wants to merge 2 commits intomasterfrom
tobibako45 wants to merge 2 commits intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
owlCarousel2runtime error caused by an undefinedautovariable and fix several small HTML markup issues affecting accessibility and layout.Description
autoPlay: autowithautoPlay: trueinjs/main.jsto ensure the carousel autoplay setting is valid.<sapn>typos to valid<span>elements inindex.htmlto fix broken markup.<li>from the friends list to normalize the list structure.rel="noopener noreferrer"to external links that usetarget="_blank"to improve security.Testing
git diff -- js/main.js index.htmlto review changes and it completed successfully.rg -n "sapn|autoPlay: auto|target=\"_blank\"" index.html js/main.jsand found no remaining issues, which succeeded.git commit -m "Fix markup issues and carousel autoplay config"and the commit succeeded.Codex Task