fix: Respect XDG_CONFIG_HOME and XDG_CACHE_HOME environment variables#146
Open
fix: Respect XDG_CONFIG_HOME and XDG_CACHE_HOME environment variables#146
Conversation
|
Please merge, I need this for Docker security - my root file system is read only. |
|
With openclaw affected by this, this will blow up... |
|
This would resolve so many issues related to multi-agent memory seperation in OpenClaw. |
- Replace better-sqlite3 with bun:sqlite - Replace fast-glob with Bun.Glob - Replace child_process.spawn with Bun.spawn - Replace crypto.createHash with Bun.CryptoHasher - Replace picomatch with Bun.Glob - Remove better-sqlite3, fast-glob, picomatch, tsx, vitest from deps - Add @types/bun, change engine to bun>=1.0.0 - Update launcher script for bun - Add setSQLiteFromBrewPrefixEnv for macOS sqlite-vec support - Remove src/db.ts compatibility layer (use bun:sqlite directly) - Change .js imports to bare specifiers - Use import.meta.main instead of fileURLToPath check
- Add XDG_CACHE_HOME support for model cache directory in llm.ts - (XDG_CONFIG_HOME for collections.ts already in upstream) - (XDG_CACHE_HOME for db path already in upstream store.ts)
- Add EmbedFormat type and ModelConfig interface to collections.ts - Add models? field to CollectionConfig for YAML config - Add detectEmbedFormat() for auto-detection from model URI - Add getEmbedFormat() with caching for format-aware embedding - Make formatQueryForEmbedding/formatDocForEmbedding format-aware - Add loadModelConfig() to read from YAML and merge with defaults - Add modelDisplayName() helper for human-readable model names - Modify getDefaultLlamaCpp() to use loadModelConfig() for model URIs - Add commented models: section to example-index.yml
- Replace embedContexts[] with single embedContext - Replace rerankContexts[] with single rerankContext - Remove computeParallelism() and threadsPerContext() methods - Simplify ensureEmbedContext() to create single context with promise guard - Simplify ensureRerankContext() to create single context (no overrides) - Simplify embedBatch() to use single context with Promise.all - Simplify rerank() to use single context with rankAndSort() - Simplify ensureLlama() to just getLlama() without manual GPU detection - Remove getLlamaGpuTypes import (not needed with simplified approach)
- showHelp displays model names from config with (custom) indicator - embed/pull/vsearch/query commands use loadModelConfig() for model URIs - Version 1.0.7-rui.1 printed by --version flag
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #132 by adding proper support for XDG Base Directory Specification.
Changes
XDG_CONFIG_HOMEsupport in getConfigDir() forindex.ymllocationXDG_CACHE_HOMEsupport for model cache directory inllm.tsTesting
Verified that:
index.yml) is written to$XDG_CONFIG_HOME/qmd/when setindex.sqlite) is written to$XDG_CACHE_HOME/qmd/when set~/.config/qmd/and~/.cache/qmd/when XDG vars not setQMD_CONFIG_DIRoverride still works (takes precedence)Fixes #132