Open
Conversation
Not all YouTube Music URLs include the video ID in the URL. This checks that any URL on a YouTube domain actually includes the video ID before trying to parse it to get the thumbnail. Without this check, the extension would throw an exception on most YouTube Music pages, which prevented YTM tabs from being shown in the extension's UI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not all YouTube Music URLs include the video ID in the URL. This checks that any URL on a YouTube domain actually includes the video ID before trying to parse it to get the thumbnail.
Without this check, the extension would throw an exception on most YouTube Music pages, which prevented YTM tabs from being shown in the extension's UI.
It is possible that this also fixes some of the causes of Issue #5 but I'm not sure of the root cause in every situation that bug encompasses so I don't know for sure.