Skip to content

Fix non-virtual destructor warning in ProgressPrinter base class #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tnagler merged 3 commits into from
Jan 12, 2026
Merged

Fix non-virtual destructor warning in ProgressPrinter base class #80

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0af37a1
add virtual destructor in ProgressPrinter class
SpatLyu Jan 12, 2026
57cf75e
Increment version number to 2.2.0.9000
SpatLyu Jan 12, 2026
bc8dd26
upgrade roxygen version to `7.3.3`
SpatLyu Jan 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions DESCRIPTION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Package: RcppThread
Title: R-Friendly Threading in C++
Version: 2.2.0
Version: 2.2.0.9000
Authors@R: c(
person("Thomas", "Nagler",, "mail@tnagler.com", role = c("aut", "cre"),
comment = c(ORCID = "0000-0003-1855-0046"))
Expand All @@ -12,7 +12,7 @@ License: MIT + file LICENSE
Encoding: UTF-8
URL: https://github.com/tnagler/RcppThread
BugReports: https://github.com/tnagler/RcppThread/issues
RoxygenNote: 7.3.2.9000
RoxygenNote: 7.3.3
Suggests:
testthat,
R.rsp,
Expand Down
2 changes: 2 additions & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# RcppThread (development version)

# RcppThread 2.2.0

NEW FEATURE
Expand Down
3 changes: 3 additions & 0 deletions inst/include/RcppThread/Progress.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,9 @@ class ProgressPrinter {
, startTime_(std::chrono::steady_clock::now())
{}

// Add virtual destructor
virtual ~ProgressPrinter() = default;

//! prints progress whenever an update is necessary.
virtual void printProgress() = 0;

Expand Down
Loading