feat: use process-file to allow eval-buffer to work over tramp#34
Open
DinoChiesa wants to merge 1 commit intotminor:mainfrom
Open
feat: use process-file to allow eval-buffer to work over tramp#34DinoChiesa wants to merge 1 commit intotminor:mainfrom
DinoChiesa wants to merge 1 commit intotminor:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Modify
jsonnet-eval-bufferto useprocess-file, instead ofcall-processMotivation and Context
jsonnet-eval-bufferpreviously used call-process. This works for synchronous, local processes.When emacs is visiting a .jsonnet file over TRAMP, for example with a filespec like
/ssh:remote-machine:~/dev/myfile.jsonnet,call-processinvokes jsonnet locally. This fails: the jsonnet program cannot access or read the remote file.By moving to
process-file, the jsonnet program runs on the remote machine and can access the remote file. To make this work, jsonnet must be installed and available on the PATH of the remote machine.Have you written tests for your change?
No tests
Types of changes
Checklist: