[embedlite-components] Add support for site specific UA override. Contributes to JB#34904#95
Open
rainemak wants to merge 1 commit intotmeshkova:masterfrom
Open
[embedlite-components] Add support for site specific UA override. Contributes to JB#34904#95rainemak wants to merge 1 commit intotmeshkova:masterfrom
rainemak wants to merge 1 commit intotmeshkova:masterfrom
Conversation
Contributor
Author
|
This also fixed navigator.userAgent when user agent overriding is implied. |
…tributes to JB#34904 This makes possible to use general.useragent.override.* overrides with simple replace syntax given that complex override is not applied. Instantiation of the UserAgent is deferred a bit so that we do not end up initializing UserAgentOverrides before general.useragent.override is applied. As UserAgent was initialized on that application startup, the simple hash separated user agent fixing did not work. This happened because nsIHttpProtocolHandler was not yet aware of the override. Thus, causing UserAgentOverrides to fail to replace ua.
rainemak
force-pushed
the
siteSpecificOverride
branch
from
03c48ce to
a353298
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes possible to use general.useragent.override.* overrides
with simple replace syntax given that complex override is not applied.
Instantiation of the UserAgent is deferred a bit so that we do not
end up initializing UserAgentOverrides before general.useragent.override
is applied. As UserAgent was initialized on that application startup,
the simple hash separated user agent fixing did not work. This happened
because nsIHttpProtocolHandler was not yet aware of the override.
Thus, causing UserAgentOverrides to fail to replace ua.