[embedlite-components] Fix compilation against system nspr.#85
Open
tworaz wants to merge 1 commit intotmeshkova:masterfrom
tworaz:for_upstream/system_nspr
Open
[embedlite-components] Fix compilation against system nspr.#85tworaz wants to merge 1 commit intotmeshkova:masterfrom tworaz:for_upstream/system_nspr
tworaz wants to merge 1 commit intotmeshkova:masterfrom
tworaz:for_upstream/system_nspr
Conversation
Don't hardcode the system nspr path to /usr/include/nspr4. Instead use pkg-config to determine correct path. Do it only in case we're building the code against system nspr. In case we use bundled gecko version system include paths should not be passed to the compiler.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't hardcode the system nspr path to /usr/include/nspr4. Instead use
pkg-config to determine correct path. Do it only in case we're building
the code against system nspr. In case we use bundled gecko version
system include paths should not be passed to the compiler.