[embedlite-components] Tweak UA override for youtube.com. Fixes JB#31713#80
Open
tworaz wants to merge 1 commit intotmeshkova:masterfrom
tworaz:for_upstream/youtube_ua_fix
Open
[embedlite-components] Tweak UA override for youtube.com. Fixes JB#31713#80tworaz wants to merge 1 commit intotmeshkova:masterfrom tworaz:for_upstream/youtube_ua_fix
tworaz wants to merge 1 commit intotmeshkova:masterfrom
tworaz:for_upstream/youtube_ua_fix
Conversation
It seems youtube has changed it user agent recognition logic again which results in sailfish-browser receiving content which relies on external android youtube app for actual video playback. This basically breaks youtube playback on sailfish. The fix seems to be rather simple. Don't drop Maemo and Mobile keywords from the UA. When youtube servers get UA with Android, Maemo and Mobile keywords they again give us version of the page with HTML5 video element.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems youtube has changed it user agent recognition logic again which
results in sailfish-browser receiving content which relies on external
android youtube app for actual video playback. This basically breaks
youtube playback on sailfish.
The fix seems to be rather simple. Don't drop Maemo and Mobile keywords
from the UA. When youtube servers get UA with Android, Maemo and Mobile
keywords they again give us version of the page with HTML5 video
element.