Add dite/time input with default value with a defined range#425
Open
RafikLkr wants to merge 3 commits intotmbo:masterfrom
Open
Add dite/time input with default value with a defined range#425RafikLkr wants to merge 3 commits intotmbo:masterfrom
RafikLkr wants to merge 3 commits intotmbo:masterfrom
Conversation
tmbo
approved these changes
Aug 28, 2025
Owner
tmbo
left a comment
tmbo
left a comment
There was a problem hiding this comment.
looks great, thanks for this additional feature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the problem that this PR addresses?
This PR addresses the need to verify the handling of default values and the validation of date input prompts. Specifically, it ensures that when the user presses "Enter" without providing a date, the default date value is correctly returned. Additionally, this PR introduces functionality to validate if the input date falls within a defined range, with a minimum and maximum date that can be specified.
Closes #121 (assuming this is the issue related to the functionality being tested)
How did you solve it?
I implemented a unit test for the date input prompt. The test simulates a scenario where the user presses "Enter" without providing a date, which should return the default value specified (in this case, "2023-01-01"). The test uses create_pipe_input to simulate the user input and DummyOutput to handle output, verifying that the expected default value is returned correctly.
Checklist