Skip to content

Conversation

@chenyuzhen
Copy link

add -C -A -B option ,function similar to grep

thx

chenyuzhen

@danielg4
Copy link

Hi. I previously submitted a PR on top of that:
maelnor#1

@xloem
Copy link
Contributor

xloem commented Oct 29, 2020

is this resolved? could it be closed if so, so that visitors can understand the repository more easily?

@danielg4
Copy link

There are three competing patches, which must still be reconciled…

@tmbinc
Copy link
Owner

tmbinc commented Feb 21, 2021

Thanks!

There's similar functionality in dump_context. While I like that this doesn't require lseek, it doesn't actually work if the search string is near the start of the buffer, i.e. near multiples of 1024-len(searchstring). Also, it changes the output format for the search results.

I'm favorable to a change that supports dumping context without lseek, but it would need to work in all cases.

I'm closing this for now because the basic functionality is available, but if any improvements on the current strategy are desired, I'm happy to take them.

@tmbinc tmbinc closed this Feb 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants