Skip to content

Fixed crashing when forcefully unwrapping running application #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hahaSK wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fixed crashing when forcefully unwrapping running application #85

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e8d1f2a
Imported Cocoa - fixed AXError not found
hahaSK Oct 14, 2021
04cbe98
Fixed crashing of forcefully unwrapping
hahaSK Oct 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Sources/AXPropertyDelegate.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import Foundation
import AXSwift
import PromiseKit
import AppKit

/// Implements PropertyDelegate using the AXUIElement API.
class AXPropertyDelegate<T: Equatable, UIElement: UIElementType>: PropertyDelegate {
Expand Down
6 changes: 3 additions & 3 deletions Sources/Application.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,10 +112,10 @@ final class OSXApplicationDelegate<
var isHidden: WriteableProperty<OfType<Bool>>!

var processIdentifier: pid_t!
lazy var runningApplication: NSRunningApplication =
NSRunningApplication(processIdentifier: self.processIdentifier)!
lazy var runningApplication: NSRunningApplication? =
NSRunningApplication(processIdentifier: self.processIdentifier)
lazy var bundleIdentifier: String? =
self.runningApplication.bundleIdentifier
self.runningApplication?.bundleIdentifier

var knownWindows: [WindowDelegate] {
return windows.map({ $0 as WindowDelegate })
Expand Down