Incorporate improvements from iot-rocket fork#17
Merged
Conversation
`github.ref` should be only `main`, not `refs/heads/main`
… test coverage Major enhancements to the Chrome devcontainer feature: - Add support for Chrome release channels (stable, beta, dev) - Add display mode options (headless, xvfb, vnc) with proper dependencies - Add VNC clipboard support configuration - Add optional font packages for CJK, emoji, and proper rendering - Add architecture detection (Chrome only supports amd64) - Install xdotool and wmctrl for X11 window automation - Improve wrapper script with better error handling and verification - Remove requirement for --add-host runArg (no longer needed) - Add shared memory configuration guidance for heavy workloads - Correct Puppeteer/Playwright auto-discovery documentation Test improvements: - Add 10+ new test scenarios covering all configuration options - Add tests for channel selection, display modes, extensions, VNC, and combined features - Expand scenarios.json with comprehensive test matrix
Google's apt repository names the dev channel package "google-chrome-unstable", not "google-chrome-dev". Map the user-facing "dev" option value to the correct package name. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Integrates improvements from @iot-rocket's fork (authored by Andreas Meichelböck), rebased onto main with conflicts resolved.
New Feature
gitlab— GitLab CLI (glab) and VS Code GitLab Workflow extensionClaude Code Enhancements
latest,stable, or a specific semver (e.g.1.0.58)stablechannel test scenario; cleaner custom user testChrome Major Overhaul (1.0.2 → 2.3.0)
stable,beta,dev)headless,xvfb,vnc(via desktop-lite)Install Script Hardening
DEBIAN_FRONTEND=noninteractiveon all install scriptsrm -rf /var/lib/apt/lists/*cleanup after apt (smaller layers)/usr/local/binCI/CD Workflow Improvements
fail-fast: false,timeout-minutes,concurrencygroups withcancel-in-progresspermissions: contents: read(least privilege)validate.yml→validate.yamlrename for consistencydefault_branchinstead of hardcodedmainAttribution
All feature work by Andreas Meichelböck / iot-rocket. Rebased onto main with conflict resolution (overlapping native installer migration, Node.js version alignment, URL branding fixes).
Test plan
gitlabfeature installs correctlystableversion option works🤖 Generated with Claude Code