Refactor to a single Zuul filter#3
Open
apnicjim wants to merge 1 commit intotlm:feature/SCRUM-3692from
Open
Conversation
Owner
|
Cheers, But this isn't going to work. Specifically Zuul has an error filter type that it relies on. I have had to disable and override the default one the spring injects. Unless there is specific tangible improvement I don't think I am willing to invest any more time in this. Its very functional at the moment and conforms to what I consider the standard design pattern when using Zuul. Focus at the moment is on testing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is what I mean by 1 Zuul filter. It should remove the need for the error handler to untangle the framework exceptions. I've kept the refactoring to a minimum in order keep this PR clear, though I think there are more opportunities, e.g. pass the RDAPRequestPath instead of a Zuul context.