Skip to content

Refactor to a single Zuul filter#3

Open
apnicjim wants to merge 1 commit intotlm:feature/SCRUM-3692from
apnicjim:feature/SCRUM-3692
Open

Refactor to a single Zuul filter#3
apnicjim wants to merge 1 commit intotlm:feature/SCRUM-3692from
apnicjim:feature/SCRUM-3692

Conversation

@apnicjim
Copy link

This is what I mean by 1 Zuul filter. It should remove the need for the error handler to untangle the framework exceptions. I've kept the refactoring to a minimum in order keep this PR clear, though I think there are more opportunities, e.g. pass the RDAPRequestPath instead of a Zuul context.

@tlm
Copy link
Owner

tlm commented Jul 16, 2017

Cheers,

But this isn't going to work. Specifically Zuul has an error filter type that it relies on. I have had to disable and override the default one the spring injects.

Unless there is specific tangible improvement I don't think I am willing to invest any more time in this. Its very functional at the moment and conforms to what I consider the standard design pattern when using Zuul.

Focus at the moment is on testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants