Open
Conversation
dokato
commented
Feb 10, 2022
Collaborator
Author
dokato
left a comment
dokato
left a comment
There was a problem hiding this comment.
In general it's a nicely written function, but with no docs it's hard to follow.
| @@ -0,0 +1,16 @@ | |||
| apply_vaccine_to_population <- function(population, ndoses, threshold_age) { | |||
Collaborator
Author
There was a problem hiding this comment.
please add (roxygen) documentation to this function
| apply_vaccine_to_population <- function(population, ndoses, threshold_age) { | ||
| for (individual in population) { | ||
| if (ndoses > 0) { | ||
| if (indiv["age"] > threshold_age || indiv["isAtRisk"]) { |
Collaborator
Author
There was a problem hiding this comment.
probably you meant individual here
| inject_first_jab(indiv) | ||
| } | ||
| } | ||
| ndoses <- ndoses - 1 |
Collaborator
Author
There was a problem hiding this comment.
you should check max/min values of ndoses
| for (individual in population) { | ||
| if (ndoses > 0) { | ||
| if (indiv["age"] > threshold_age || indiv["isAtRisk"]) { | ||
| if (indiv["hasFirstJab"]) { |
Collaborator
Author
There was a problem hiding this comment.
you should consider all the cases in that condition
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.