Skip to content

Conversation

@damiendoligez
Copy link
Contributor

Follow-up to #148 (comment)
Should make #186 unnecessary.

cc @kape1395

Signed-off-by: Damien Doligez <damien.doligez@inria.fr>
@damiendoligez damiendoligez force-pushed the optimize-level-computation branch from 38e62e0 to 14bd9b3 Compare February 4, 2025 23:46
@kape1395
Copy link
Collaborator

I tried to use these changes with the updated_enabled_cdot branch.
It still takes 10s of seconds to parse the document.

@damiendoligez
Copy link
Contributor Author

Can you provide the TLA file, if it's not confidential? Do you have a recipe for reproducing the problem on the command line? That would be much more convenient for tracking down the slowdown.

@damiendoligez damiendoligez merged commit b36a425 into tlaplus:main Mar 11, 2025
5 checks passed
@damiendoligez damiendoligez deleted the optimize-level-computation branch March 11, 2025 14:38
@kape1395
Copy link
Collaborator

I'm sorry for the late response.

For example, the slow behaviour can be observed with https://github.com/tlaplus/CommunityModules/blob/master/modules/FiniteSetsExt_theorems_proofs.tla and tlapm build from branch https://github.com/tlaplus/tlapm/tree/updated_enabled_cdot-optimize-level-computation.

The VSCode/LSP blocks for 5-8 seconds on my machine after each edit (or before the proof step icons are shown).
But maybe that's related to the parser's use in LSP, since running tlapm --toolbox 0 0 FiniteSetsExt_theorems_proofs.tla doesn't look slow. At least it doesn't wait 5 seconds before reporting the first obligations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants