0.11 stable #6
Open
0.11 stable #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…url contains '/' in query string
… the remove_ helper so that AR doesn't skip callbacks
Update copyright year in license to 2014
…-cache-storage Make cache storage pluggable
This will give us a few extra pieces to work with to name
a certain thumbnail for something. For instance:
```ruby
def default_url(*args)
vname = version_name || args.first
[model.mounted_as.to_s, vname, "default"].join("_")
end
```
This will allow us to call `model.attachment.url(:not_a_version)` and still
return "attachment_not_a_version_default", which is useful in cases of
conditional versioning.
…ve-helpers-dirty Make the #remove_ accessor set the mounted column as changed
…ted-rmagick-loading Skip loading RMagick if already loaded
[ci skip]
Switch to SVG badges in readme
With the release of Fog v1.20.0, it is possible to only require the specific parts of Fog that you need, e.g. `require "fog/aws/storage"` which will load 36 classes, whereas `require "fog"` loads 698 classes in my tests.
generator_spec has a dependency on Railties, which defines the Rails module, apparently without defining the .env method that is needed when testing on Rails 4.1. See https://github.com/rails/rails/blob/v4.1.0/activerecord/lib/active_record/connection_handling.rb#L3
…ation-fixup Fixes deprecated File.exists?
…fix-4.1-specs Only require generator_spec when needed
We don't need to require all of Fog using ~> 1.20
Adding support for jRuby.
…agick_resize_and_pad Fix default gravity in MiniMagick resize_and_pad helper
…ort-rspec3 supported rspec3 matcher protocols
Fix small typo for fog and require in gemfile
width and height methods for image processing
Silence rspec 3 complains
According to http://guides.rubyonrails.org/active_record_querying.html, chapter 1.3, you should never use .all.each when iterating over the whole table.
.all.each is highly inefficient with many rows
Fix cache workfile collision between versions
…xtension Change image extension when converting formats.
Make example in README more clear.
Remove fog version from the README.
Change max-age from 10 years (315576000 seconds) to 1 year (31557600) (the actual maximum), as per carrierwaveuploader#1466 Just as I was making this edit, I realized that it is even more convenient to say `365.day` (as opposed to `1.year`), as it enables people to easily change the number to 1.day or 7.day or 14.day or 30.day, etc., in accordance with what makes sense for their application.
update README.md wrt Cache-Control max-age
…ly-on-mime-gem-file-extensions-order to be future changes-proof don't rely on mime gem file extensions order
…he-only Add the cache_only configuration option
Fix grammar (pluralize file to files)
cleanup gemspec Dir.glob
# Conflicts: # .travis.yml # History.md # carrierwave.gemspec # lib/carrierwave/processing/rmagick.rb # spec/spec_helper.rb # spec/support/activerecord.rb
# Conflicts: # .travis.yml # History.md # carrierwave.gemspec # lib/carrierwave/processing/rmagick.rb # spec/spec_helper.rb # spec/support/activerecord.rb
# Conflicts: # .travis.yml # History.md # carrierwave.gemspec # lib/carrierwave/processing/rmagick.rb # spec/spec_helper.rb # spec/support/activerecord.rb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
17 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.