TKTC-16 Add photo handling to Member and MemberData models #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced `photoRaw` property to both `Member` and `MemberData` structs to store raw HTML for member photos. - Implemented `MemberPhoto` struct to parse and represent member photos, including URL, alt text, and tags. - Enhanced photo parsing logic to handle various HTML formats and normalize alt text. - Added unit tests to validate photo parsing functionality, ensuring robustness against different input scenarios.
vamsii777
changed the title
- Introduced `SalesforceFilesRoutes` protocol and its implementation for downloading files from Salesforce. - Added `FileDownloadResponse` model to encapsulate file data and metadata. - Enhanced `SalesforceClient` to include file handling routes and a method for authenticating and downloading files. - Implemented error handling for file download operations, ensuring robust responses for various failure scenarios. - Updated documentation to reflect new file download capabilities and usage examples.
Member
Author
|
- Updated `SalesforceFilesRoutesImpl` to extract `ContentDocumentId` from response headers, improving the file download process. - Replaced placeholder logic with dynamic retrieval of `ContentDocumentId` from `ContentDocumentId` and `X-ContentDocumentId` headers, ensuring accurate handling of file downloads.
- Updated `.spi.yml` to include `SalesforceClient` in documentation targets. - Introduced `FilesHandler` protocol and `SalesforceFilesHandler` implementation for downloading files from Salesforce. - Enhanced `CongregationKit` and its protocol to support file operations, adding a `files` property. - Updated documentation to reflect new file management features and usage examples, including secure file download capabilities. - Refactored `CongregationKit` documentation to include file-related services and models.
- Updated the `MemberPhoto` struct to conform to the new `SalesforceFileURLRepresentable` protocol, adding functionality to identify Salesforce file URLs and extract record IDs. - Introduced a new `SalesforceFileURLRepresentable` protocol for handling Salesforce file URLs, including properties for the original URL and record ID extraction. - Added an initializer to `MemberPhoto` for better instantiation and clarity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
photoRawproperty to bothMemberandMemberDatastructs to store raw HTML for member photos.MemberPhotostruct to parse and represent member photos, including URL, alt text, and tags.