Skip to content

Introduce responsive padding #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tklepzig merged 1 commit into from
Jan 7, 2026
Merged

Introduce responsive padding #44

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/famous-bulldogs-sing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"ada-ui": minor
---

Added separate padding tokens that are responsive, unlike the already existing
spacing tokens
31 changes: 30 additions & 1 deletion index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
<body>
<div
class="compound-commands vertical"
style="position: sticky; top: var(--spacing)"
style="position: sticky; top: var(--padding)"
>
<div class="spacer"></div>
<a
Expand All @@ -31,6 +31,7 @@
data-label="Typography"
data-abbr="Typo"
></a>
<a href="#padding" class="command shade1">Padding</a>
<a href="#spacing" class="command shade1">Spacing</a>
<a href="#colors" class="command shade1">Colors</a>
<a href="#page-layout" class="command shade1">Page Layout</a>
Expand Down Expand Up @@ -104,6 +105,29 @@
</article>
<footer></footer>
</div>
<div class="panel">
<header><h2 id="padding">Padding</h2></header>
<article class="padding">
<code>--padding-xs</code>
<span>0.15rem</span>
<div class="padding-box xs shade2"></div>
<code>--padding-sm</code>
<span>0.4rem</span>
<div class="padding-box sm shade2"></div>
<code>--padding</code>
<span>0.75rem</span>
<div class="padding-box shade2"></div>
<code>--padding-lg</code>
<span>1rem</span>
<div class="padding-box lg shade2"></div>
<p>&rarr; Paddings are responsive (in rem).</p>
<p>
Usage: paddings, anything which should grow/shrink with the
font-size
</p>
</article>
<footer></footer>
</div>
<div class="panel">
<header><h2 id="spacing">Spacing</h2></header>
<article class="spacing">
Expand All @@ -119,6 +143,11 @@
<code>--spacing-lg</code>
<span>14px</span>
<div class="spacing-box lg shade3"></div>
<p>&rarr; Spacings are not responsive (in px).</p>
<p>
Usage: spacings, gaps, anything which should be stable regardless
of the font-size
</p>
</article>
<footer></footer>
</div>
Expand Down
4 changes: 2 additions & 2 deletions scss/_command.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
border-style: solid;
border-color: transparent;
border-width: var(--border-width);
padding: var(--spacing-xs) var(--spacing-sm);
padding: var(--padding-xs) var(--padding-sm);
min-height: 3rem;
min-width: 3rem;
border-radius: var(--border-radius);
Expand Down Expand Up @@ -95,7 +95,7 @@
font-size: var(--scale-3xl);
line-height: var(--scale-3xl);
align-self: center;
padding: var(--spacing-xs);
padding: var(--padding-xs);
}

> .command,
Expand Down
6 changes: 5 additions & 1 deletion scss/_global.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,10 @@
--scale-2xl: 1.6rem;
--scale-3xl: 1.8rem;
--box-shadow: 0 0 10px 0 rgba(0, 0, 0, 0.4);
--padding-xs: 0.15rem;
--padding-sm: 0.4rem;
--padding: 0.75rem;
--padding-lg: 1rem;
--spacing-xs: 2px;
--spacing-sm: 6px;
--spacing: 10px;
Expand Down Expand Up @@ -50,7 +54,7 @@ html {

body {
font-size: 1rem;
padding: var(--spacing);
padding: var(--padding);
background: var(--bg-body);
color: var(--fg-body);
transition: background-color 0.15s ease-in-out;
Expand Down
2 changes: 1 addition & 1 deletion scss/_input.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
font-family: inherit;
background-color: transparent;
transition: border-color 0.15s ease-in-out;
padding: var(--spacing);
padding: var(--padding);
font-size: var(--scale-base);

&:focus {
Expand Down
6 changes: 3 additions & 3 deletions scss/_panel.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
@extend %header;
font-size: var(--scale-2xl);

padding: var(--spacing-sm) var(--spacing);
padding: var(--padding-sm) var(--padding);

&:empty {
padding: 0;
Expand All @@ -55,15 +55,15 @@

> article {
z-index: 1;
padding: var(--spacing);
padding: var(--padding);
overflow: auto;

@extend %scrollbar;
}
> footer {
position: relative;

padding: var(--spacing-sm) var(--spacing);
padding: var(--padding-sm) var(--padding);
font-size: var(--scale-sm);
text-align: right;

Expand Down
47 changes: 46 additions & 1 deletion style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ body {

@media (max-width: 48rem) {
grid-template-columns: 1fr;
gap: var(--spacing-xs);
gap: var(--padding-xs);
}
}
}
Expand Down Expand Up @@ -120,6 +120,14 @@ body {
gap: var(--spacing);
align-items: center;

> p {
grid-column: span 3;

&:first-of-type {
margin-top: var(--padding-lg);
}
}

> .spacing-box {
display: inline-block;
background: var(--color500);
Expand All @@ -143,6 +151,43 @@ body {
}
}

.padding {
display: grid;
grid-template-columns: repeat(2, auto) 1fr;
gap: var(--spacing);
align-items: center;

> p {
grid-column: span 3;

&:first-of-type {
margin-top: var(--padding-lg);
}
}

> .padding-box {
display: inline-block;
background: var(--color500);
width: var(--padding);
height: var(--padding);

&.xs {
width: var(--padding-xs);
height: var(--padding-xs);
}

&.sm {
width: var(--padding-sm);
height: var(--padding-sm);
}

&.lg {
width: var(--padding-lg);
height: var(--padding-lg);
}
}
}

input {
max-width: 20rem;
}