Support bytes as base64 in codegen #77
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emostov
commented
Jan 26, 2026
| } | ||
|
|
||
| // Verify the field type is Vec<u8> | ||
| if !is_vec_u8(&field.ty) { |
Contributor
Author
There was a problem hiding this comment.
This is safer, but might cause the codegen to silently ignore manually added items in BASE64_FIELDS. I figure if we go with the generalized approach later we can re-use this fn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates codegen logic to allow manually specifying exact fields that we should deserialize as base64. I saw two options: we could assume all
Vec<u8>fields where base64 or we could manually specify exact fields to assume arebase64. Since this is the first time we have a bytes field in our API I chose the latter, but if we decide to standardize on all bytes fields being base64, we may want to generally assume in the generation code.I also synced protos with mono