Skip to content

Conversation

@DidierMetral
Copy link

@DidierMetral DidierMetral commented Oct 11, 2024

Add dash and uppercase in url regexp

Proposed change

Add the possibility to use all allowed chars in standard URL (lowercase, uppercase, digits, dot and dash)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass.
  • There is no commented out code in this PR.
  • The code has been formatted (make lint)
  • Tests have been added to verify that the new code works.

Add dash and uppercase in url regexp
@DidierMetral
Copy link
Author

Can a maintainer review this fix (ping @tkdrob)? The workflow is awaiting approval from a maintainer.

Copy link
Author

@DidierMetral DidierMetral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review ok ?

@jim-edwards
Copy link

Any way we can help get this through? I am hitting this and unable to change my DNS as the provider I use now makes it required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Regex doesn't allow dash in domain names

2 participants