Skip to content

Conversation

@joostlek
Copy link

Proposed change

I wanted to implement the diagnostics platform in HA since I was suffering from a bug, and to put the coordinator data to dict, all fields should be present, so I checked my response and it seems the current implementation is outdated.

I synced the system health object with the one described in the docs. I would also like to go over the rest when I set up my development environment
https://radarr.video/docs/api/#/System/get_api_v3_system_status

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass.
  • There is no commented out code in this PR.
  • The code has been formatted (make lint)
  • Tests have been added to verify that the new code works.

@tkdrob
Copy link
Owner

tkdrob commented Jul 31, 2023

What version of Radarr do you have? I'd also like to see the tests updated to include the new attributes if any (hard to tell at a glance) or enums

@joostlek
Copy link
Author

I just cloned it and was indeed checking the tests if there were any. I currently run at 4.5.2.7388

@tkdrob
Copy link
Owner

tkdrob commented Aug 3, 2023

So all the ones you marked optional you don't have? I plan on moving this package to pydantic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants