Update TeacherTicketDetailActivity.java#2
Open
renaaliu wants to merge 1 commit intotjiang11:masterfrom
Open
Conversation
tjiang11
reviewed
Jan 12, 2019
|
|
||
| int id = item.getItemId(); | ||
|
|
||
| //option to select all tickets for a class to export all |
Owner
There was a problem hiding this comment.
- Use the same indentation as the other lines.
- Most style guides will say to leave a space between '//' and the beginning of your comment. Also, capitalization is nice!
- Probably clearer to say 'Add an option to export all tickets for a class.' Full sentences are nice too when possible!
- The typical workflow would be to instead just file a GitHub bug https://github.com/tjiang11/Tcrunch/issues. Personally for this project, since I did it alone I just used a separate doc to track my work. Just do whatever best fits your work style!
With that all being said, you don't have to do any of them because those really only matter if you're collaborating with more people. But at the same time, it's nice to have pretty code for yourself to look at that you wrote :) And if you ever share this project on your resume, people may poke around!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I'm currently working with John to update/improve the app. I've currently placed comments about proposed improvements in the code, and am planning on revising the code soon as well.