-
Notifications
You must be signed in to change notification settings - Fork 0
Bug 1847784: Provide a Theme to FedCM Provider Dialog #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: bug1842203-fedcm-provider-prompt
Are you sure you want to change the base?
Bug 1847784: Provide a Theme to FedCM Provider Dialog #1
Conversation
ba08d2f to
7011ba0
Compare
| data class IdentityCredentialColors( | ||
| val title: Color, | ||
| val description: Color, | ||
| val ripple: Color, | ||
| ) | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was wondering if we could have a generic theme that could be used for other AC components that want to use compose, similar to what we have on FirefoxColors, we don't need something that detailed but something generic enough that could be used in other components. What do you think?
f572f8f to
b7375e1
Compare
7011ba0 to
5ec277a
Compare
c306f5d to
fd91e12
Compare
fd91e12 to
c97c888
Compare
Amejia481
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for putting the PR!
This looks good to me!
…dialogs in Compose
b7375e1 to
53a2b6b
Compare
c97c888 to
ea704d4
Compare
42f4c97 to
eadef48
Compare
Pull Request checklist
After merge
To download an APK when reviewing a PR (after all CI tasks finished running):
Checksat the top of the PR page.firefoxci-taskclustergroup on the left to expand all tasks.build-apk-{fenix,focus,klar}-debugtask you're interested in.View task in Taskclusterin the newDETAILSsection.GitHub Automation
Used by GitHub Actions.