Skip to content

Conversation

@titooan
Copy link
Owner

@titooan titooan commented Aug 30, 2023

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Breaking Changes: If this is a breaking Android Components change, please push a draft PR on Reference Browser to address the breaking issues.

To download an APK when reviewing a PR (after all CI tasks finished running):

  1. Click on Checks at the top of the PR page.
  2. Click on the firefoxci-taskcluster group on the left to expand all tasks.
  3. Click on the build-apk-{fenix,focus,klar}-debug task you're interested in.
  4. Click on View task in Taskcluster in the new DETAILS section.
  5. The APK links should be on the right side of the screen, named for each CPU architecture.

GitHub Automation

Used by GitHub Actions.

@titooan titooan force-pushed the bug1847784-fedcm-compose-theme branch 2 times, most recently from ba08d2f to 7011ba0 Compare August 30, 2023 21:19
Comment on lines 13 to 18
data class IdentityCredentialColors(
val title: Color,
val description: Color,
val ripple: Color,
)

Copy link

@Amejia481 Amejia481 Aug 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering if we could have a generic theme that could be used for other AC components that want to use compose, similar to what we have on FirefoxColors, we don't need something that detailed but something generic enough that could be used in other components. What do you think?

@titooan titooan force-pushed the bug1842203-fedcm-provider-prompt branch from f572f8f to b7375e1 Compare August 31, 2023 19:22
@titooan titooan force-pushed the bug1847784-fedcm-compose-theme branch from 7011ba0 to 5ec277a Compare August 31, 2023 20:12
@titooan titooan marked this pull request as draft August 31, 2023 21:29
@titooan titooan force-pushed the bug1847784-fedcm-compose-theme branch 3 times, most recently from c306f5d to fd91e12 Compare September 6, 2023 20:41
@titooan titooan force-pushed the bug1847784-fedcm-compose-theme branch from fd91e12 to c97c888 Compare September 18, 2023 18:45
@titooan titooan marked this pull request as ready for review September 18, 2023 18:46
Copy link

@Amejia481 Amejia481 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting the PR!
This looks good to me!

@titooan titooan force-pushed the bug1842203-fedcm-provider-prompt branch from b7375e1 to 53a2b6b Compare September 18, 2023 18:49
@titooan titooan force-pushed the bug1847784-fedcm-compose-theme branch from c97c888 to ea704d4 Compare September 18, 2023 18:51
@titooan titooan force-pushed the bug1842203-fedcm-provider-prompt branch 8 times, most recently from 42f4c97 to eadef48 Compare September 22, 2023 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants