Skip to content

Extract table elements even if they are not inside the <body> tag. #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
hdabaghyan wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Extract table elements even if they are not inside the <body> tag. #172

hdabaghyan wants to merge 1 commit into from

Conversation

@hdabaghyan
Copy link

@hdabaghyan hdabaghyan commented Oct 1, 2025

Issue: #171

@hdabaghyan hdabaghyan mentioned this pull request Oct 1, 2025
Open
@Michael-E-Rose
Copy link
Collaborator

Michael-E-Rose commented Oct 1, 2025

Thanks a million for this!

May there be any side effects of this change? Like, what is a table outside the body? Is that common or is that rather a bug in PubMed?

@hdabaghyan
Copy link
Author

hdabaghyan commented Oct 1, 2025 •
edited
Loading

May there be any side effects of this change? Like, what is a table outside the body? Is that common or is that rather a bug in PubMed?

Here is the structure of the nxml file, where I encountered the issue.
image

And documentation here suggests that article could be divided to different blocks. One of which is <float-groups>, which can contain tables.

I am not very familiar with this format, but I guess it is a valid use case.

Side effect of this change could be, that parser will collect a table that is not in an expected tag. Alternative fix could be to find all the tags that are supposed to contain tables, and write xpath for all such cases.
But I would rather collect any table information, regardless where it is.(though, this is my perspective)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hdabaghyan @Michael-E-Rose