Skip to content

Conversation

@huntc
Copy link
Contributor

@huntc huntc commented Aug 9, 2025

Provides a string encoding/decoding for KV paths.

@huntc huntc requested a review from Copilot August 9, 2025 21:30
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements string encoding and decoding functionality for KV paths by adding Display and FromStr traits to the Path type. The implementation uses URL encoding to handle special characters and introduces a quoting mechanism to distinguish string names from numeric values.

  • Adds Display trait implementation for converting paths to string representation with URL encoding
  • Adds FromStr trait implementation for parsing paths from strings with error handling
  • Introduces comprehensive test coverage for both encoding and decoding scenarios

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
edfsm-kv-store/src/path.rs Implements Display and FromStr traits for Path with URL encoding/decoding logic and comprehensive tests
edfsm-kv-store/Cargo.toml Adds url-escape dependency for URL encoding functionality
Cargo.toml Adds url-escape workspace dependency

@arnolddevos arnolddevos mentioned this pull request Aug 10, 2025
@huntc huntc merged commit bd5aa7a into titanclass:main Aug 10, 2025
1 check passed
@huntc huntc deleted the path-string branch August 10, 2025 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants