Disable edfsm-machine default dependencies

[huntc]

Defaults shouldn't be enabled for transitive lib dependencies. They can create additive issues downstream e.g. when using with WASM.

[arnolddevos]

Does this change have any practical effect? Changing workspace dependencies only matters if they are used in the workspace somewhere, right? Changing dev-dependencies does not affect the build.

[huntc]

Does this change have any practical effect? Changing workspace dependencies only matters if they are used in the workspace somewhere, right? Changing dev-dependencies does not affect the build.

You're correct. However, I think the default features disablement in the workspace is more correct anyhow. Also, edfsm-kvstore was previously depending on evfsm-machine with default features, so it did matter then.

However, the more important change here is the removal of a dependency on edfsm-machine by the edfsm-kvstore. Given that removal, we no longer transitiviely enable the default features of edfsm-machine when depending on edfsm-kvstore. I have just re-proved this with my project that is WASM and therefore doesn't cope with edfsm-machine and default features.

[arnolddevos]

removal of a dependency on edfsm-machine by the edfsm-kvstore

But you removed the dev dependency and left the build dependency. The build dependency is optional but required by the tokio feature (see async_query.rs) Also the tokio feature remains a default feature in kv-store (which I am OK with).

[arnolddevos]

I don't think any changes are needed here. The tokio dep in edfsm-machine is on feature "sync" only and is require. The machine dep in edfsm-kv-store is optional but necessary when compiling async_query. The tokio dep is again on "sync" only.